Re: [PATCH] fetch: fix compilation warning

[Junio C Hamano]

Ramsay Jones  writes:

> You probably already know, but I had to add this on top of the 'pu'
> branch to get a clean compile tonight (your 'jc/war-on-string-list'
> branch).

It was not just about squelching a warning but simply broken code
that deserved to be warned/errored.  I think what we have in 'pu'
now is already fixed.

Thanks.

>   }
>   hashmap_free(_refs, 1);
> - string_list_clear(_refs, 0);
> + string_list_clear(_refs_list, 0);
>  }
>  
>  static struct ref *get_ref_map(struct remote *remote,

[PATCH] fetch: fix compilation warning

[Ramsay Jones]

commit 440fc7c0729 ("fetch: replace string-list used as a look-up
table with a hashmap", 2018-09-25) renamed a string-list variable
(while adding a hashmap of the same name) and forgot to rename the
string-list variable in a call to string_list_clear().

Signed-off-by: Ramsay Jones 
---

Hi Junio,

You probably already know, but I had to add this on top of the 'pu'
branch to get a clean compile tonight (your 'jc/war-on-string-list'
branch).

Thanks!

ATB,
Ramsay Jones

 builtin/fetch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 0a71953bc5..aea2e10364 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -391,7 +391,7 @@ static void find_non_local_tags(const struct ref *refs,
}
}
hashmap_free(_refs, 1);
-   string_list_clear(_refs, 0);
+   string_list_clear(_refs_list, 0);
 }
 
 static struct ref *get_ref_map(struct remote *remote,
-- 
2.19.0