Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
Daniel Baumann writes: > On 07/25/2018 12:54 PM, Ævar Arnfjörð Bjarmason wrote: >> The code you're modifying doesn't exist in the "pu" branch since >> 249d626f2c > > indeed, thanks. > >> From looking at it it seems we no longer have this problem, >> but perhaps you'd like to check that out for yourself? > Yes, it's not needed anymore at all, yay! > > Sorry for the noise. Thanks for reporting. It is 100% better to see occasional duplicates than nothing.
Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
Hi, On 07/25/2018 12:54 PM, Ævar Arnfjörð Bjarmason wrote: > The code you're modifying doesn't exist in the "pu" branch since > 249d626f2c indeed, thanks. > From looking at it it seems we no longer have this problem, > but perhaps you'd like to check that out for yourself? Yes, it's not needed anymore at all, yay! Sorry for the noise. Regards, Daniel
Re: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
On Wed, Jul 25 2018, Daniel Baumann wrote: > the attached patch removes a superfluous tab indentation in the > interactive git-rebase messages. > > It would be nice to get rid of this to avoid visual disturbance with > whitespace highlighting editors. The code you're modifying doesn't exist in the "pu" branch since 249d626f2c ("rebase--interactive: rewrite append_todo_help() in C", 2018-07-10), rebase is being rewritten in C. From looking at it it seems we no longer have this problem, but perhaps you'd like to check that out for yourself?
[PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase
Hi, the attached patch removes a superfluous tab indentation in the interactive git-rebase messages. It would be nice to get rid of this to avoid visual disturbance with whitespace highlighting editors. Regards, Daniel >From 353eb1c2c44d5117a3fad1323ca6852b13e4c86a Mon Sep 17 00:00:00 2001 From: Daniel Baumann Date: Wed, 25 Jul 2018 11:58:40 +0200 Subject: [PATCH] git-rebase--interactive.sh: Remove superfluous tab in rebase file Removing superfluous tab indentation in interactive git-rebase file to avoid visual disturbance with whitespace highlighting editors. Signed-off-by: Daniel Baumann --- git-rebase--interactive.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 299ded213..0bf9eefad 100644 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -224,7 +224,7 @@ EOF gettext " However, if you remove everything, the rebase will be aborted. - " | git stripspace --comment-lines >>"$todo" +" | git stripspace --comment-lines >>"$todo" if test -z "$keep_empty" then -- 2.18.0