Re: [PATCH] git-remote-mediawiki: do not remove installed files in clean target
Matthieu Moy wrote: Jonathan Nieder jrnie...@gmail.com writes: Running make clean after a successful make install should not result in a broken mediawiki remote helper. Acked-by: Matthieu Moy matthieu@imag.fr Thanks for looking it over. Here are a few more makefile tweaks on top of that one. Jonathan Nieder (3): git-remote-mediawiki: honor DESTDIR in make install git-remote-mediawiki build: make 'install' command configurable git-remote-mediawiki build: handle DESTDIR/INSTLIBDIR with whitespace contrib/mw-to-git/Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] git-remote-mediawiki: do not remove installed files in clean target
Jonathan Nieder jrnie...@gmail.com writes: Matthieu Moy wrote: Jonathan Nieder jrnie...@gmail.com writes: Running make clean after a successful make install should not result in a broken mediawiki remote helper. Acked-by: Matthieu Moy matthieu@imag.fr Thanks for looking it over. Here are a few more makefile tweaks on top of that one. All look good to me. Is it intentional that you didn't Cc Junio? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] git-remote-mediawiki: do not remove installed files in clean target
Jonathan Nieder jrnie...@gmail.com writes: Running make clean after a successful make install should not result in a broken mediawiki remote helper. Acked-by: Matthieu Moy matthieu@imag.fr Ideally, there could be a make uninstall removing the installed file. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] git-remote-mediawiki: do not remove installed files in clean target
Running make clean after a successful make install should not result in a broken mediawiki remote helper. Reported-by: Thorsten Glaser t.gla...@tarent.de Signed-off-by: Jonathan Nieder jrnie...@gmail.com --- Thanks for the very pleasant mediawiki remote helper. contrib/mw-to-git/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/contrib/mw-to-git/Makefile b/contrib/mw-to-git/Makefile index f206f96..c5547f9 100644 --- a/contrib/mw-to-git/Makefile +++ b/contrib/mw-to-git/Makefile @@ -43,7 +43,6 @@ install: install_pm clean: $(MAKE) -C $(GIT_ROOT_DIR) SCRIPT_PERL=$(SCRIPT_PERL_FULL) \ clean-perl-script - rm $(INSTLIBDIR)/$(GIT_MEDIAWIKI_PM) perlcritic: perlcritic -5 $(SCRIPT_PERL) -- 1.8.4.1 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
