Re: [PATCH] http: release strbuf on disabled alternates

2017-03-03 Thread Jeff King
On Sat, Mar 04, 2017 at 01:50:16AM +, Eric Wong wrote:

> This likely has no real-world impact on memory usage,
> but it is cleaner for future readers.

Yep, this looks good.

-Peff


[PATCH] http: release strbuf on disabled alternates

2017-03-03 Thread Eric Wong
This likely has no real-world impact on memory usage,
but it is cleaner for future readers.

Fixes: abcbdc03895f ("http: respect protocol.*.allow=user for http-alternates")
Signed-off-by: Eric Wong 
---
 http-walker.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/http-walker.c b/http-walker.c
index b34b6ace7c..2c85316112 100644
--- a/http-walker.c
+++ b/http-walker.c
@@ -314,6 +314,8 @@ static void process_alternates_response(void *callback_data)
while (tail->next != NULL)
tail = tail->next;
tail->next = newalt;
+   } else {
+   strbuf_release();
}
}
}
-- 
EW