Re: [PATCH] patch reply
I just sent a patch to a new thread which is not what I wanted. However I already sent the same patch a few days ago: https://public-inbox.org/git/CAK7vU=2ePR3jQsgu=rxsmrxytaahqxc0sfrn5yozlzqzp2z...@mail.gmail.com/ 2017-10-17 6:01 GMT+02:00 Junio C Hamano : > Thais Diniz writes: > >> +Just to clarify I did not see Marius patch. >> +Did see Marius' comment saying he would look it in the leftoverbits list, >> +but since i didn't see any patch i thought i could work on it and did so >> based on Stephan's comment >> +(which i suppose Mario also did and that is why the code resulted to be >> similar). > > In any case, both versions share exactly the same "don't call > get_multi() to grab the same configuration values from inside the > callback of git_config()" issue, so whoever works on it to complete > the topic, it needs further work.
Re: [PATCH] patch reply
Thais Diniz writes: > +Just to clarify I did not see Marius patch. > +Did see Marius' comment saying he would look it in the leftoverbits list, > +but since i didn't see any patch i thought i could work on it and did so > based on Stephan's comment > +(which i suppose Mario also did and that is why the code resulted to be > similar). In any case, both versions share exactly the same "don't call get_multi() to grab the same configuration values from inside the callback of git_config()" issue, so whoever works on it to complete the topic, it needs further work.
[PATCH] patch reply
From: Thais Diniz Braz --- emailReply | 4 1 file changed, 4 insertions(+) create mode 100644 emailReply diff --git a/emailReply b/emailReply new file mode 100644 index 0..2d591b55b --- /dev/null +++ b/emailReply @@ -0,0 +1,4 @@ +Just to clarify I did not see Marius patch. +Did see Marius' comment saying he would look it in the leftoverbits list, +but since i didn't see any patch i thought i could work on it and did so based on Stephan's comment +(which i suppose Mario also did and that is why the code resulted to be similar). -- 2.15.0.rc0.39.g2f0e14e.dirty