Re: [PATCH] t5400: remove dead code

2014-12-16 Thread Junio C Hamano
Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] t5400: remove dead code

2014-12-15 Thread Stefan Beller
Signed-off-by: Stefan Beller sbel...@google.com
---

Notes:
When debugging the atomic push series I wondered if we want to have
tests for the atomic push as well as for atomic send-pack.
So I looked at the t5400 test if I could easily add tests for send-pack.
I don't think I will add tests in here, but I found dead code.
Also I am rambling about the other series this patch is totally unrelated.

Removing dead code is always a joy!

Thanks,
Stefan

 t/t5400-send-pack.sh | 16 +---
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh
index 0736bcb..04cea97 100755
--- a/t/t5400-send-pack.sh
+++ b/t/t5400-send-pack.sh
@@ -76,8 +76,7 @@ test_expect_success 'refuse pushing rewound head without 
--force' '
test $victim_head = $pushed_head
 '
 
-test_expect_success \
-'push can be used to delete a ref' '
+test_expect_success 'push can be used to delete a ref' '
( cd victim  git branch extra master ) 
git send-pack ./victim :extra master 
( cd victim 
@@ -196,19 +195,6 @@ rewound_push_setup() {
)
 }
 
-rewound_push_succeeded() {
-   cmp ../parent/.git/refs/heads/master .git/refs/heads/master
-}
-
-rewound_push_failed() {
-   if rewound_push_succeeded
-   then
-   false
-   else
-   true
-   fi
-}
-
 test_expect_success 'pushing explicit refspecs respects forcing' '
rewound_push_setup 
parent_orig=$(cd parent  git rev-parse --verify master) 
-- 
2.2.0.31.gad78000.dirty

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html