[PATCH 0/2] solaris test fixups

2014-01-23 Thread Jeff King 
Due to the alignment bug in another thread, I had the pleasure of
visiting my old friend Solaris 9 today. The tests _almost_ all run out
of the box.

This series features two minor fixes:

  [1/2]: t7501: fix empty commit test with NO_PERL
  [2/2]: t7700: do not use touch -r

I had a few other failures related to encodings; I suspect the problem
is simply that the machine in question doesn't have eucJP support at
all.

The big one that I did not fix is in t7001-mv. We do this:

  test_must_fail git mv some-file no-such-dir/

and assume that it will fail. It doesn't. Solaris happily renames
some-file to a regular file named no-such-dir. So we fail later during
the index-update, complaining about adding the entry no-such-dir/, but
still exit(0) at the end. I'm mostly willing to just call Solaris crazy
for allowing the rename (Linux returns ENOTDIR), but I do wonder if
the index codepath could be improved (and especially to return an
error).

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] solaris test fixups

2014-01-23 Thread Junio C Hamano 
Jeff King p...@peff.net writes:

 and assume that it will fail. It doesn't. Solaris happily renames
 some-file to a regular file named no-such-dir. So we fail later during
 the index-update, complaining about adding the entry no-such-dir/, but
 still exit(0) at the end. I'm mostly willing to just call Solaris crazy
 for allowing the rename (Linux returns ENOTDIR), but I do wonder if
 the index codepath could be improved (and especially to return an
 error).

I think j6t has a patch for that, a8933469 (mv: let 'git mv file
no-such-dir/' error out on Windows, too, 2014-01-08).


--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] solaris test fixups

2014-01-23 Thread Jeff King 
On Thu, Jan 23, 2014 at 12:52:30PM -0800, Junio C Hamano wrote:

 Jeff King p...@peff.net writes:
 
  and assume that it will fail. It doesn't. Solaris happily renames
  some-file to a regular file named no-such-dir. So we fail later during
  the index-update, complaining about adding the entry no-such-dir/, but
  still exit(0) at the end. I'm mostly willing to just call Solaris crazy
  for allowing the rename (Linux returns ENOTDIR), but I do wonder if
  the index codepath could be improved (and especially to return an
  error).
 
 I think j6t has a patch for that, a8933469 (mv: let 'git mv file
 no-such-dir/' error out on Windows, too, 2014-01-08).

Ah yeah, that looks like exactly the same issue (and the fix looks sane
from my cursory investigation). Thanks for the pointer. I wasn't
planning to look further into it, but now I can do so without feeling
guilty. :)

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html