Re: [PATCH 0/3] nd/multiple-work-trees updates

2015-03-18 Thread Duy Nguyen
On Wed, Mar 18, 2015 at 3:04 PM, Ephrim Khong dr.kh...@gmail.com wrote:
 Without having looked into this and nd/multiple-work-trees, but with make
 multiple checkouts aware of each other in mind: Could this mechanism be
 re-used to make alternates aware of each other, to mitigate the dangers of
 having  git gc  on an alternate remove objects that are used by a
 referencing repository?

If we can turn on ref namespace and make $GIT_DIR/config and hooks per
worktree, I think it may have a chance of replacing alternate object
mechanism entirely: one object database, one ref database (but refs of
each worktree is namespaced so no conflicts), multiple worktrees,
multiple config files, multiple hooks.

Because some config keys affect object database, having
multiple/conflicting config keys imply that this worktree may change
object database in a way trhat  impacts performance (not correctness)
of another worktree. Later on when we have multiple ref backends, if
config keys can change ref backend behavior (or even choose the
backend), we may run into other problems. This problem might go away
if we define that those global config keys can't be per-worktree..

In short, I am good at confusing people.
-- 
Duy
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/3] nd/multiple-work-trees updates

2015-03-18 Thread Ephrim Khong
Without having looked into this and nd/multiple-work-trees, but with 
make multiple checkouts aware of each other in mind: Could this 
mechanism be re-used to make alternates aware of each other, to mitigate 
the dangers of having  git gc  on an alternate remove objects that are 
used by a referencing repository?


Thanks
- Eph

On 03.01.2015 10:41, Nguyễn Thái Ngọc Duy wrote:

These patches are on top of what's in 'pu'. They add
--ignore-other-worktrees and make a note about current submodule
support status. I don't think submodule support is ready yet even
with Max Kirillov's series [1]. His 03/03 is already fixed in 'pu'
though, so only 01/03 and 02/03 are new.

[1] http://thread.gmane.org/gmane.comp.version-control.git/261107

Nguyễn Thái Ngọc Duy (3):
   checkout: pass whole struct to parse_branchname_arg instead of individual 
flags
   checkout: add --ignore-other-wortrees
   git-checkout.txt: a note about multiple checkout support for submodules

  Documentation/git-checkout.txt |  9 +
  builtin/checkout.c | 19 +++
  t/t2025-checkout-to.sh |  7 +++
  3 files changed, 27 insertions(+), 8 deletions(-)



--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/3] nd/multiple-work-trees updates

2015-02-13 Thread Dennis Kaarsemaker
On do, 2015-02-12 at 14:57 -0800, Junio C Hamano wrote:
 Nguyễn Thái Ngọc Duy  pclo...@gmail.com writes:
 
  These patches are on top of what's in 'pu'. They add
  --ignore-other-worktrees and make a note about current submodule
  support status. I don't think submodule support is ready yet even
  with Max Kirillov's series [1]. His 03/03 is already fixed in 'pu'
  though, so only 01/03 and 02/03 are new.
 
  [1] http://thread.gmane.org/gmane.comp.version-control.git/261107
 
 With the understanding (perhaps a strongly-worded paragraph in the
 release notes) that this is not suitable for submodule users yet,
 is this in a good enough shape to go to 'next'?

I've been using this for a while and really like it. However, it needs a
few fixups to merge with next as there are a few merge conflicts.

(A version of this branch that I stuck on top of next last week can be
found at https://github.com/seveas/git/tree/nd/multiple-work-trees )
-- 
Dennis Kaarsemaker
http://www.kaarsemaker.net

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/3] nd/multiple-work-trees updates

2015-02-13 Thread Duy Nguyen
On Fri, Feb 13, 2015 at 5:57 AM, Junio C Hamano gits...@pobox.com wrote:
 Nguyễn Thái Ngọc Duy  pclo...@gmail.com writes:

 These patches are on top of what's in 'pu'. They add
 --ignore-other-worktrees and make a note about current submodule
 support status. I don't think submodule support is ready yet even
 with Max Kirillov's series [1]. His 03/03 is already fixed in 'pu'
 though, so only 01/03 and 02/03 are new.

 [1] http://thread.gmane.org/gmane.comp.version-control.git/261107

 With the understanding (perhaps a strongly-worded paragraph in the
 release notes) that this is not suitable for submodule users yet,
 is this in a good enough shape to go to 'next'?

I'm not aware of any problems on this series (except submodules). So, yes.
-- 
Duy
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/3] nd/multiple-work-trees updates

2015-02-12 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy  pclo...@gmail.com writes:

 These patches are on top of what's in 'pu'. They add
 --ignore-other-worktrees and make a note about current submodule
 support status. I don't think submodule support is ready yet even
 with Max Kirillov's series [1]. His 03/03 is already fixed in 'pu'
 though, so only 01/03 and 02/03 are new.

 [1] http://thread.gmane.org/gmane.comp.version-control.git/261107

With the understanding (perhaps a strongly-worded paragraph in the
release notes) that this is not suitable for submodule users yet,
is this in a good enough shape to go to 'next'?

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/3] nd/multiple-work-trees updates

2015-02-12 Thread Jens Lehmann

Am 13.02.2015 um 11:57 schrieb Junio C Hamano:

Nguyễn Thái Ngọc Duy  pclo...@gmail.com writes:


These patches are on top of what's in 'pu'. They add
--ignore-other-worktrees and make a note about current submodule
support status. I don't think submodule support is ready yet even
with Max Kirillov's series [1]. His 03/03 is already fixed in 'pu'
though, so only 01/03 and 02/03 are new.

[1] http://thread.gmane.org/gmane.comp.version-control.git/261107


With the understanding (perhaps a strongly-worded paragraph in the
release notes) that this is not suitable for submodule users yet,
is this in a good enough shape to go to 'next'?


No objections from my side (and maybe we should also add a warning
that *all* worktree-related configuration - e.g. EOL options - are
currently always shared between all worktrees).

Adding submodule support can then be done in another series (and
renaming core.worktree to something else is definitely *not* the
way to do that! ;-).
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/3] nd/multiple-work-trees updates

2015-02-12 Thread Mark Levedahl

On 02/12/2015 06:51 PM, Jens Lehmann wrote:

Am 13.02.2015 um 11:57 schrieb Junio C Hamano:

Nguyễn Thái Ngọc Duy pclo...@gmail.com writes:


These patches are on top of what's in 'pu'. They add
--ignore-other-worktrees and make a note about current submodule
support status. I don't think submodule support is ready yet even
with Max Kirillov's series [1]. His 03/03 is already fixed in 'pu'
though, so only 01/03 and 02/03 are new.

[1] http://thread.gmane.org/gmane.comp.version-control.git/261107


With the understanding (perhaps a strongly-worded paragraph in the
release notes) that this is not suitable for submodule users yet,
is this in a good enough shape to go to 'next'?


No objections from my side (and maybe we should also add a warning
that *all* worktree-related configuration - e.g. EOL options - are
currently always shared between all worktrees).

Adding submodule support can then be done in another series (and
renaming core.worktree to something else is definitely *not* the
way to do that! ;-).

I concur the patch series is good enough for next. Better multiple 
worktree support for submodules is, I think, a sizeable topic that will 
take a while to settle, so should be worked after this base is integrated.


Mark
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/3] nd/multiple-work-trees updates

2015-01-03 Thread Nguyễn Thái Ngọc Duy
These patches are on top of what's in 'pu'. They add
--ignore-other-worktrees and make a note about current submodule
support status. I don't think submodule support is ready yet even
with Max Kirillov's series [1]. His 03/03 is already fixed in 'pu'
though, so only 01/03 and 02/03 are new.

[1] http://thread.gmane.org/gmane.comp.version-control.git/261107

Nguyễn Thái Ngọc Duy (3):
  checkout: pass whole struct to parse_branchname_arg instead of individual 
flags
  checkout: add --ignore-other-wortrees
  git-checkout.txt: a note about multiple checkout support for submodules

 Documentation/git-checkout.txt |  9 +
 builtin/checkout.c | 19 +++
 t/t2025-checkout-to.sh |  7 +++
 3 files changed, 27 insertions(+), 8 deletions(-)

-- 
2.2.0.84.ge9c7a8a

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html