On Fri, Jun 24, 2016 at 07:05:14PM +0200, Johannes Sixt wrote:
> Am 24.06.2016 um 18:46 schrieb Jeff King:
> > On Fri, Jun 24, 2016 at 06:38:55PM +0200, Johannes Sixt wrote:
> > > It's going to be 269 with ksh, and who-knows-what on Windows (due to lack
> > > of
> > > SIGPIPE - I haven't tested this, yet).
> >
> > Thanks, I meant to ask about that. We do a workaround in t0005, but we
> > _don't_ do it in the new sigpipe handling for test_must_fail. Is the
> > latter just broken, too?
>
> That's well possible. It is not prepared to see ksh's exit codes for
> signals.
I'm actually not convinced that old versions of ksh are viable for
running the test suite. mksh seems to use POSIX semantics, and I cannot
get through t0005 with ksh93, as it parses nested parentheses wrong. But
maybe there are other ksh variants that use the funny exit codes, but
are otherwise not too buggy.
I'd be more concerned with Windows. The SIGPIPE tests in t0005 are
already marked !MINGW, but other checks elsewhere are not. I know there
is no SIGPIPE on Windows, so it may be that some cases happen to work
because we end up in write_or_die(), which converts EPIPE into a 141
exit.
Anyway. Here's a series that I think makes things better, and it is not
too painful to do.
[1/4]: tests: factor portable signal check out of t0005
[2/4]: t0005: use test_match_signal as appropriate
[3/4]: test_must_fail: use test_match_signal
[4/4]: t/lib-git-daemon: use test_match_signal
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
