Re: [PATCH 0/6] Fix the shallow deepen bug with no-done

2014-02-07 Thread Jonathan Nieder
Duy Nguyen wrote:

 Don't take it the wrong way. I was just summarizing the last round. It
 surprised me though that this went under my radar. Perhaps a bug
 tracker is not a bad idea after all (if Jeff went missing, this bug
 could fall under the crack)

I'm happy to plug
- http://bugs.debian.org/cgi-bin/pkgreport.cgi?src=git;include=tags:upstream
- http://packages.qa.debian.org/common/index.html (email subscription link:
  source package = git; under Advanced it's possible to subscribe to
  bug-tracking system emails and skip e.g. the automated build stuff)
- https://www.debian.org/Bugs/Reporting (bug reporting interface -
  unfortunately the important part is buried under Sending the bug
  report via e-mail)
again. :)
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/6] Fix the shallow deepen bug with no-done

2014-02-07 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes:

 Duy Nguyen wrote:

 Don't take it the wrong way. I was just summarizing the last round. It
 surprised me though that this went under my radar. Perhaps a bug
 tracker is not a bad idea after all (if Jeff went missing, this bug
 could fall under the crack)

 I'm happy to plug
 - http://bugs.debian.org/cgi-bin/pkgreport.cgi?src=git;include=tags:upstream
 - http://packages.qa.debian.org/common/index.html (email subscription link:
   source package = git; under Advanced it's possible to subscribe to
   bug-tracking system emails and skip e.g. the automated build stuff)
 - https://www.debian.org/Bugs/Reporting (bug reporting interface -
   unfortunately the important part is buried under Sending the bug
   report via e-mail)
 again. :)

Then I'd add my bits ;-)

http://git-blame.blogspot.com/p/leftover-bits.html

Admittedly I haven't touched it for a while, as I usually update it
during a lull, often in the pre-release -rc freeze period, but the
list has been quite active during -rc this cycle.

I probably should start dropping any new topics on the list and find
leftover bits during this cycle.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/6] Fix the shallow deepen bug with no-done

2014-02-06 Thread Nguyễn Thái Ngọc Duy
Reported by Jeff [1]. Junio spotted it right but nobody made any move
since then. The main fix is 6/6. The rest is just updates while I was
looking at it. 2/6 may need fast track though.

[1] http://thread.gmane.org/gmane.comp.version-control.git/219914

Nguyễn Thái Ngọc Duy (6):
  test: rename http fetch and push test files
  t5538: fix default http port
  pack-protocol.txt: clarify 'obj-id' in the last ACK after 'done'
  protocol-capabilities.txt: refer multi_ack_detailed back to pack-protocol.txt
  protocol-capabilities.txt: document no-done
  fetch-pack: fix deepen shallow over smart http with no-done cap

 Documentation/technical/pack-protocol.txt  |  3 ++-
 Documentation/technical/protocol-capabilities.txt  | 18 
 fetch-pack.c   |  3 ++-
 t/t5537-fetch-shallow.sh   | 24 ++
 t/t5538-push-shallow.sh|  2 +-
 ...5540-http-push.sh = t5540-http-push-webdav.sh} |  0
 t/{t5541-http-push.sh = t5541-http-push-smart.sh} |  0
 ...5550-http-fetch.sh = t5550-http-fetch-dumb.sh} |  0
 ...551-http-fetch.sh = t5551-http-fetch-smart.sh} |  0
 9 files changed, 47 insertions(+), 3 deletions(-)
 rename t/{t5540-http-push.sh = t5540-http-push-webdav.sh} (100%)
 rename t/{t5541-http-push.sh = t5541-http-push-smart.sh} (100%)
 rename t/{t5550-http-fetch.sh = t5550-http-fetch-dumb.sh} (100%)
 rename t/{t5551-http-fetch.sh = t5551-http-fetch-smart.sh} (100%)

-- 
1.8.5.2.240.g8478abd

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/6] Fix the shallow deepen bug with no-done

2014-02-06 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy  pclo...@gmail.com writes:

 Reported by Jeff [1]. Junio spotted it right but nobody made any move
 since then.

Hrm.  Was I supposed to make any move at that point?  The discussion
ended by me asking a question what happens if we did X? and there
was no discussion.

 The main fix is 6/6. The rest is just updates while I was
 looking at it. 2/6 may need fast track though.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/6] Fix the shallow deepen bug with no-done

2014-02-06 Thread Jeff King
On Thu, Feb 06, 2014 at 11:31:02AM -0800, Junio C Hamano wrote:

 Nguyễn Thái Ngọc Duy  pclo...@gmail.com writes:
 
  Reported by Jeff [1]. Junio spotted it right but nobody made any move
  since then.
 
 Hrm.  Was I supposed to make any move at that point?  The discussion
 ended by me asking a question what happens if we did X? and there
 was no discussion.

No, you were rightly waiting on me. I queued it on my todo list but
haven't gotten around to it (and hadn't received any reports since the
original, so didn't consider it high priority). I picked it off my todo
list and stuck it on the bug list under insanely hard for fun (because
I think the diagnosis probably would have been beyond a first-time git
contributor).

Thanks very much for looking at (and fixing!) this, Duy.

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/6] Fix the shallow deepen bug with no-done

2014-02-06 Thread Duy Nguyen
On Fri, Feb 7, 2014 at 2:31 AM, Junio C Hamano gits...@pobox.com wrote:
 Nguyễn Thái Ngọc Duy  pclo...@gmail.com writes:

 Reported by Jeff [1]. Junio spotted it right but nobody made any move
 since then.

 Hrm.  Was I supposed to make any move at that point?  The discussion
 ended by me asking a question what happens if we did X? and there
 was no discussion.

Don't take it the wrong way. I was just summarizing the last round. It
surprised me though that this went under my radar. Perhaps a bug
tracker is not a bad idea after all (if Jeff went missing, this bug
could fall under the crack)
-- 
Duy
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html