Re: [PATCH 00/17] Make the msvc-build scripts work again
From: Junio C Hamano gits...@pobox.com Philip Oakley philipoak...@iee.org writes: Hopefully it's not too late in the cycle for a review of this contrib/compat item. Has this been discussed in the Windows land and folks are all happy with this change? If so the only thing we would need review on the main list is the top-level change outside compat/ and contrib/, so it may be possible to sneak it in before -rc1. Yes this had been discussed previously on the MsysGit list, and in the referenced Pull Request [msysgit/#318] https://github.com/msysgit/git/pull/318/files. I had aspirations of a slightly bigger series that would also allow the VS compiled output to be installed but that had stalled, so I cut back to fixing the basic 'make it work' steps. The series has been reordered/rebased, and the recently noticed 05/17 err msg fix added. The one unknown is the last patch [17] for the Windows Safe Exception Handling in that the default acceptability was flipped in VS2013 so that zlib became unacceptable to ceratain OS versions without the addition of that option -SAFESEH:NO, but I haven't been able to test that myself (I don't have a complaining system). Otherwise, no, but we can still polish it during the prerelease freeze and aim to merge it in the first batch after the upcoming release. Philip Oakley (17): .gitignore: improve MSVC ignore patterns .gitignore: ignore library directories created by MSVC VS2008 buildsystem (msvc-build) Vcproj.pm: remove duplicate GUID Makefile: a dry-run can error out if no perl. Document the issue engine.pl: fix error message (lib-link) engine.pl: Avoid complications with perl support engine.pl: Properly accept quoted spaces in filenames engine.pl: Fix i18n -o option in msvc buildsystem generator engine.pl: ignore invalidcontinue.obj which is known to MSVC engine.pl: name the msvc buildsystem's makedry error file engine.pl: delete the captured stderr file if empty engine.pl: add debug line to capture the dry-run engine.pl: provide more debug print statements Vcproj.pm: list git.exe first to be startup project vcbuild/readme: Improve layout and reference msvc-build script msvc-build: add complete Microsoft Visual C compilation script config.mak.uname: add MSVC No_SafeExeceptionHandler option .gitignore| 8 ++- Makefile | 3 ++ compat/vcbuild/README | 27 +++--- compat/vcbuild/scripts/msvc-build | 89 +++ config.mak.uname | 9 contrib/buildsystems/Generators/Vcproj.pm | 34 ++-- contrib/buildsystems/engine.pl| 37 ++--- 7 files changed, 174 insertions(+), 33 deletions(-) create mode 100644 compat/vcbuild/scripts/msvc-build mode change 100755 = 100644 contrib/buildsystems/engine.pl Why? Mistake on/by Windows? - My mistake, I hadn't noticed it had happened. I can search out the change step and re-roll. -- Philip -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/17] Make the msvc-build scripts work again
Philip Oakley philipoak...@iee.org writes: Hopefully it's not too late in the cycle for a review of this contrib/compat item. Has this been discussed in the Windows land and folks are all happy with this change? If so the only thing we would need review on the main list is the top-level change outside compat/ and contrib/, so it may be possible to sneak it in before -rc1. Otherwise, no, but we can still polish it during the prerelease freeze and aim to merge it in the first batch after the upcoming release. Philip Oakley (17): .gitignore: improve MSVC ignore patterns .gitignore: ignore library directories created by MSVC VS2008 buildsystem (msvc-build) Vcproj.pm: remove duplicate GUID Makefile: a dry-run can error out if no perl. Document the issue engine.pl: fix error message (lib-link) engine.pl: Avoid complications with perl support engine.pl: Properly accept quoted spaces in filenames engine.pl: Fix i18n -o option in msvc buildsystem generator engine.pl: ignore invalidcontinue.obj which is known to MSVC engine.pl: name the msvc buildsystem's makedry error file engine.pl: delete the captured stderr file if empty engine.pl: add debug line to capture the dry-run engine.pl: provide more debug print statements Vcproj.pm: list git.exe first to be startup project vcbuild/readme: Improve layout and reference msvc-build script msvc-build: add complete Microsoft Visual C compilation script config.mak.uname: add MSVC No_SafeExeceptionHandler option .gitignore| 8 ++- Makefile | 3 ++ compat/vcbuild/README | 27 +++--- compat/vcbuild/scripts/msvc-build | 89 +++ config.mak.uname | 9 contrib/buildsystems/Generators/Vcproj.pm | 34 ++-- contrib/buildsystems/engine.pl| 37 ++--- 7 files changed, 174 insertions(+), 33 deletions(-) create mode 100644 compat/vcbuild/scripts/msvc-build mode change 100755 = 100644 contrib/buildsystems/engine.pl Why? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/17] Make the msvc-build scripts work again
This series fixes the scripts which generated Visual Studio project files. The scripts had bit rotted over the years as other commits changed the git makefile which it post processed. The series doesn't attempt to install the Visual Studio compiled product but allows Windows developers familiar with VS to support the Windows SDK port of Git. The fixes are presented in a fine grained manner. A previous patch series were at $gmane/21132 (2014-11-20), $gmane/21207 (2014-12-26), and on Msysgit list (2015-02-23) https://groups.google.com/forum/?hl=en_US?hl%3Den#!topic/msysgit/aiEVBKjRshY https://github.com/msysgit/git/pull/318/files Hopefully it's not too late in the cycle for a review of this contrib/compat item. Philip Oakley (17): .gitignore: improve MSVC ignore patterns .gitignore: ignore library directories created by MSVC VS2008 buildsystem (msvc-build) Vcproj.pm: remove duplicate GUID Makefile: a dry-run can error out if no perl. Document the issue engine.pl: fix error message (lib-link) engine.pl: Avoid complications with perl support engine.pl: Properly accept quoted spaces in filenames engine.pl: Fix i18n -o option in msvc buildsystem generator engine.pl: ignore invalidcontinue.obj which is known to MSVC engine.pl: name the msvc buildsystem's makedry error file engine.pl: delete the captured stderr file if empty engine.pl: add debug line to capture the dry-run engine.pl: provide more debug print statements Vcproj.pm: list git.exe first to be startup project vcbuild/readme: Improve layout and reference msvc-build script msvc-build: add complete Microsoft Visual C compilation script config.mak.uname: add MSVC No_SafeExeceptionHandler option .gitignore| 8 ++- Makefile | 3 ++ compat/vcbuild/README | 27 +++--- compat/vcbuild/scripts/msvc-build | 89 +++ config.mak.uname | 9 contrib/buildsystems/Generators/Vcproj.pm | 34 ++-- contrib/buildsystems/engine.pl| 37 ++--- 7 files changed, 174 insertions(+), 33 deletions(-) create mode 100644 compat/vcbuild/scripts/msvc-build mode change 100755 = 100644 contrib/buildsystems/engine.pl -- 2.3.1 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
