[PATCH 03/18] receive-pack: do not reuse old_sha1[] to other things

2014-08-19 Thread Junio C Hamano
This piece of code reads object names of shallow boundaries,
not old_sha1[].

Signed-off-by: Junio C Hamano gits...@pobox.com
---
 builtin/receive-pack.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 43f35c4..ee855b4 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -847,9 +847,11 @@ static struct command *read_head_info(struct sha1_array 
*shallow)
break;
 
if (len == 48  starts_with(line, shallow )) {
-   if (get_sha1_hex(line + 8, old_sha1))
-   die(protocol error: expected shallow sha, got 
'%s', line + 8);
-   sha1_array_append(shallow, old_sha1);
+   unsigned char sha1[20];
+   if (get_sha1_hex(line + 8, sha1))
+   die(protocol error: expected shallow sha, got 
'%s',
+   line + 8);
+   sha1_array_append(shallow, sha1);
continue;
}
 
-- 
2.1.0-301-g54593e2

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 03/18] receive-pack: do not reuse old_sha1[] to other things

2014-08-19 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes:

 This piece of code reads object names of shallow boundaries,
 not old_sha1[].

 Signed-off-by: Junio C Hamano gits...@pobox.com
 ---

I should double the subject line and say do not reuse ... for other
things.

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html