Re: [PATCH 07/16] commit-reach: move can_all_from_reach_with_flags

2018-07-16 Thread Jonathan Tan
>  /* Remember to update object flag allocation in object.h */
> +#define REACHABLE   (1u<<15)
>  #define PARENT1  (1u<<16)
>  #define PARENT2  (1u<<17)
>  #define STALE(1u<<18)

Update the object flag allocation in object.h.

> +int reachable(struct commit *from, int with_flag, int assign_flag,
> +   time_t min_commit_date)

In this and previous patches: I think it's better to use "unsigned int"
as the data type for a flag, just like in clear_commit_marks().

Other than that, this and all previous patches look good.


[PATCH 07/16] commit-reach: move can_all_from_reach_with_flags

2018-07-16 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee 

Signed-off-by: Derrick Stolee 
---
 commit-reach.c | 62 +
 commit-reach.h | 13 ++
 upload-pack.c  | 69 +-
 3 files changed, 76 insertions(+), 68 deletions(-)

diff --git a/commit-reach.c b/commit-reach.c
index 9e56f90ea..e07ff993f 100644
--- a/commit-reach.c
+++ b/commit-reach.c
@@ -9,6 +9,7 @@
 #include "commit-reach.h"
 
 /* Remember to update object flag allocation in object.h */
+#define REACHABLE   (1u<<15)
 #define PARENT1(1u<<16)
 #define PARENT2(1u<<17)
 #define STALE  (1u<<18)
@@ -531,3 +532,64 @@ int commit_contains(struct ref_filter *filter, struct 
commit *commit,
return contains_tag_algo(commit, list, cache) == CONTAINS_YES;
return is_descendant_of(commit, list);
 }
+
+int reachable(struct commit *from, int with_flag, int assign_flag,
+ time_t min_commit_date)
+{
+   struct prio_queue work = { compare_commits_by_commit_date };
+
+   prio_queue_put(, from);
+   while (work.nr) {
+   struct commit_list *list;
+   struct commit *commit = prio_queue_get();
+
+   if (commit->object.flags & with_flag) {
+   from->object.flags |= assign_flag;
+   break;
+   }
+   if (!commit->object.parsed)
+   parse_object(the_repository, >object.oid);
+   if (commit->object.flags & REACHABLE)
+   continue;
+   commit->object.flags |= REACHABLE;
+   if (commit->date < min_commit_date)
+   continue;
+   for (list = commit->parents; list; list = list->next) {
+   struct commit *parent = list->item;
+   if (!(parent->object.flags & REACHABLE))
+   prio_queue_put(, parent);
+   }
+   }
+   from->object.flags |= REACHABLE;
+   clear_commit_marks(from, REACHABLE);
+   clear_prio_queue();
+   return (from->object.flags & assign_flag);
+}
+
+int can_all_from_reach_with_flag(struct object_array *from,
+int with_flag, int assign_flag,
+time_t min_commit_date)
+{
+   int i;
+
+   for (i = 0; i < from->nr; i++) {
+   struct object *from_one = from->objects[i].item;
+
+   if (from_one->flags & assign_flag)
+   continue;
+   from_one = deref_tag(the_repository, from_one, "a from object", 
0);
+   if (!from_one || from_one->type != OBJ_COMMIT) {
+   /* no way to tell if this is reachable by
+* looking at the ancestry chain alone, so
+* leave a note to ourselves not to worry about
+* this object anymore.
+*/
+   from->objects[i].item->flags |= assign_flag;
+   continue;
+   }
+   if (!reachable((struct commit *)from_one, with_flag, 
assign_flag,
+  min_commit_date))
+   return 0;
+   }
+   return 1;
+}
diff --git a/commit-reach.h b/commit-reach.h
index 925cb05d7..ce3b963e6 100644
--- a/commit-reach.h
+++ b/commit-reach.h
@@ -56,4 +56,17 @@ define_commit_slab(contains_cache, enum contains_result);
 int commit_contains(struct ref_filter *filter, struct commit *commit,
struct commit_list *list, struct contains_cache *cache);
 
+int reachable(struct commit *from, int with_flag, int assign_flag,
+ time_t min_commit_date);
+
+/*
+ * Determine if every commit in 'from' can reach at least one commit
+ * that is marked with 'with_flag'. As we traverse, use 'assign_flag'
+ * as a marker for commits that are already visited. Do not walk
+ * commits with date below 'min_commit_date'.
+ */
+int can_all_from_reach_with_flag(struct object_array *from,
+int with_flag, int assign_flag,
+time_t min_commit_date);
+
 #endif
diff --git a/upload-pack.c b/upload-pack.c
index 96298e50e..11c426685 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -24,13 +24,13 @@
 #include "quote.h"
 #include "upload-pack.h"
 #include "serve.h"
+#include "commit-reach.h"
 
 /* Remember to update object flag allocation in object.h */
 #define THEY_HAVE  (1u << 11)
 #define OUR_REF(1u << 12)
 #define WANTED (1u << 13)
 #define COMMON_KNOWN   (1u << 14)
-#define REACHABLE  (1u << 15)
 
 #define SHALLOW(1u << 16)
 #define NOT_SHALLOW(1u << 17)
@@ -336,73 +336,6 @@ static int got_oid(const char *hex, struct object_id *oid)
return 0;
 }
 
-static int reachable(struct commit *from, int with_flag, int assign_flag,
-time_t