Re: [PATCH 1/2] Make lock local to fetch_pack
Matt Kraai kr...@ftbfs.org writes: From: Matt Kraai matt.kr...@amo.abbott.com lock is only used by fetch_pack, so move it into that function. Signed-off-by: Matt Kraai matt.kr...@amo.abbott.com --- fetch-pack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Eh, did you base your patch on something older than 2d4177c (Make fetch-pack a builtin with an internal API, 2007-09-10)??? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] Make lock local to fetch_pack
Junio C Hamano gits...@pobox.com writes: Matt Kraai kr...@ftbfs.org writes: From: Matt Kraai matt.kr...@amo.abbott.com lock is only used by fetch_pack, so move it into that function. Signed-off-by: Matt Kraai matt.kr...@amo.abbott.com --- fetch-pack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Eh, did you base your patch on something older than 2d4177c (Make fetch-pack a builtin with an internal API, 2007-09-10)??? Ah, nevermind. I see we refactored this out recently but that is still in flight. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/2] Make lock local to fetch_pack
From: Matt Kraai matt.kr...@amo.abbott.com
lock is only used by fetch_pack, so move it into that function.
Signed-off-by: Matt Kraai matt.kr...@amo.abbott.com
---
fetch-pack.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fetch-pack.c b/fetch-pack.c
index 099ff4d..9d9762d 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -874,8 +874,6 @@ static int fetch_pack_config(const char *var, const char
*value, void *cb)
return git_default_config(var, value, cb);
}
-static struct lock_file lock;
-
static void fetch_pack_setup(void)
{
static int did_setup;
@@ -896,6 +894,7 @@ struct ref *fetch_pack(struct fetch_pack_args *args,
struct string_list *sought,
char **pack_lockfile)
{
+ static struct lock_file lock;
struct stat st;
struct ref *ref_cpy;
--
1.8.1-rc1
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
