Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
From: "Stefan Beller" Further, remove duplicated space character. https://en.wikipedia.org/wiki/Sentence_spacing seems like a globally controversial thing. (I assumed it was some sort of local dialect before researching it properly) I personally do not mind one way or another regarding (double) spaces after a period, but I would think we'd strive for consistency throughout the project. The use of double spaces was a taught typing technique as recently as the early-mid 1980s when my wife did a UK university postgraduate secretarial course. This was just before PC word processing took off. It takes a long while for the old ways to die off! -- Philip
Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
On Tue, Aug 1, 2017 at 8:59 AM, Kaartic Sivaraam
wrote:
> On Mon, 2017-07-31 at 13:23 -0700, Stefan Beller wrote:
>> On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam
>> wrote:
>> > Replace the dashed version of a command with undashed
>> > version and quote it.
>>
>> I like it, but similar as below, we'd want to go for
>> consistency.
>>
> I assume you mean the consistency in quoting i.e., you're expecting the
> patch to use (") instead of (') for quoting. Correct me, if I'm wrong.
Actually I did not imply any expectation on the outcome, because I
do not know what the consistency end game looks like for this issue.
So maybe we'd want to go with the currently most used way?
(Are there only three? (a) with dash, (b) with single quotes and
(c) with double quotes?)
>> >
>> > Further, remove duplicated space character.
>>
>> https://en.wikipedia.org/wiki/Sentence_spacing
>> seems like a globally controversial thing. (I assumed
>> it was some sort of local dialect before researching
>> it properly)
>>
> Man, I had no idea about people using two spaces after period.
>
>> I personally do not mind one way or another regarding
>> (double) spaces after a period, but I would think we'd
>> strive for consistency throughout the project.
>>
> Consistency is crucial. I'll just remove that part of the patch.
>
> --
> Kaartic
[PATCH 1/2] doc: fix small issues in SubmittingPatches
Replace the dashed version of a command with undashed version and quote it. Use double quotes to quote a git command for consistency. Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 558d465b6..886fe3650 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -293,7 +293,7 @@ then you just add a line saying Signed-off-by: Random J Developer -This line can be automatically added by Git if you run the git-commit +This line can be automatically added by Git if you run the "git commit" command with the -s option. Notice that you can place your own Signed-off-by: line when @@ -380,7 +380,7 @@ their trees themselves. Know the status of your patch after submission * You can use Git itself to find out when your patch is merged in - master. 'git pull --rebase' will automatically skip already-applied + master. "git pull --rebase" will automatically skip already-applied patches, and will let you know. This works only if you rebase on top of the branch in which your patch has been merged (i.e. it will not tell you if your patch is merged in pu if you rebase on top of -- 2.14.0.rc1.434.g6eded367a
Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
On Mon, 2017-07-31 at 13:23 -0700, Stefan Beller wrote:
> On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam
> wrote:
> > Replace the dashed version of a command with undashed
> > version and quote it.
>
> I like it, but similar as below, we'd want to go for
> consistency.
>
I assume you mean the consistency in quoting i.e., you're expecting the
patch to use (") instead of (') for quoting. Correct me, if I'm wrong.
> >
> > Further, remove duplicated space character.
>
> https://en.wikipedia.org/wiki/Sentence_spacing
> seems like a globally controversial thing. (I assumed
> it was some sort of local dialect before researching
> it properly)
>
Man, I had no idea about people using two spaces after period.
> I personally do not mind one way or another regarding
> (double) spaces after a period, but I would think we'd
> strive for consistency throughout the project.
>
Consistency is crucial. I'll just remove that part of the patch.
--
Kaartic
Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
Stefan Beller writes: >> Further, remove duplicated space character. > > https://en.wikipedia.org/wiki/Sentence_spacing > seems like a globally controversial thing. (I assumed > it was some sort of local dialect before researching > it properly) > > I personally do not mind one way or another regarding > (double) spaces after a period, but I would think we'd > strive for consistency throughout the project. I am not sure if that is something we want to encourage newbies to be doing. Especially a patch like this (notice the double-space before "Go back to..." in the pre-context) makes me feel it is distracting without adding much "consistency" value. And no, I am not suggesting a tree-wide sweep to make everything consistent. >> spend their time to improve your patch. Go back to step (2). >> >> (4) The list forms consensus that the last round of your patch is >> - good. Send it to the maintainer and cc the list. >> + good. Send it to the maintainer and cc the list. >> >> (5) A topic branch is created with the patch and is merged to 'next', >> and cooked further and eventually graduates to 'master'. >> -- >> 2.14.0.rc1.434.g6eded367a >>
Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam wrote: > Replace the dashed version of a command with undashed > version and quote it. I like it, but similar as below, we'd want to go for consistency. > > Further, remove duplicated space character. https://en.wikipedia.org/wiki/Sentence_spacing seems like a globally controversial thing. (I assumed it was some sort of local dialect before researching it properly) I personally do not mind one way or another regarding (double) spaces after a period, but I would think we'd strive for consistency throughout the project. > > Signed-off-by: Kaartic Sivaraam > --- > Documentation/SubmittingPatches | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index 558d465b6..9d0dab08d 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -293,7 +293,7 @@ then you just add a line saying > > Signed-off-by: Random J Developer > > -This line can be automatically added by Git if you run the git-commit > +This line can be automatically added by Git if you run the 'git commit' > command with the -s option. > > Notice that you can place your own Signed-off-by: line when > @@ -366,7 +366,7 @@ suggests to the contributors: > spend their time to improve your patch. Go back to step (2). > > (4) The list forms consensus that the last round of your patch is > - good. Send it to the maintainer and cc the list. > + good. Send it to the maintainer and cc the list. > > (5) A topic branch is created with the patch and is merged to 'next', > and cooked further and eventually graduates to 'master'. > -- > 2.14.0.rc1.434.g6eded367a >
[PATCH 1/2] doc: fix small issues in SubmittingPatches
Replace the dashed version of a command with undashed version and quote it. Further, remove duplicated space character. Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 558d465b6..9d0dab08d 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -293,7 +293,7 @@ then you just add a line saying Signed-off-by: Random J Developer -This line can be automatically added by Git if you run the git-commit +This line can be automatically added by Git if you run the 'git commit' command with the -s option. Notice that you can place your own Signed-off-by: line when @@ -366,7 +366,7 @@ suggests to the contributors: spend their time to improve your patch. Go back to step (2). (4) The list forms consensus that the last round of your patch is - good. Send it to the maintainer and cc the list. + good. Send it to the maintainer and cc the list. (5) A topic branch is created with the patch and is merged to 'next', and cooked further and eventually graduates to 'master'. -- 2.14.0.rc1.434.g6eded367a
Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
On Sun, 2017-07-30 at 15:49 +0100, Philip Oakley wrote: > From: "Kaartic Sivaraam" > > minor nit: It's nice, for these single character changes, to give a clue in > the commit message as to what to look for. > > E.g. > > Quote the command, and remove duplicated space character > Fixed it. Will remember this in future. :) -- Kaartic
Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
From: "Kaartic Sivaraam" minor nit: It's nice, for these single character changes, to give a clue in the commit message as to what to look for. E.g. Quote the command, and remove duplicated space character -- Philip. Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 558d465b6..9d0dab08d 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -293,7 +293,7 @@ then you just add a line saying Signed-off-by: Random J Developer -This line can be automatically added by Git if you run the git-commit +This line can be automatically added by Git if you run the 'git commit' command with the -s option. Notice that you can place your own Signed-off-by: line when @@ -366,7 +366,7 @@ suggests to the contributors: spend their time to improve your patch. Go back to step (2). (4) The list forms consensus that the last round of your patch is - good. Send it to the maintainer and cc the list. + good. Send it to the maintainer and cc the list. (5) A topic branch is created with the patch and is merged to 'next', and cooked further and eventually graduates to 'master'. -- 2.14.0.rc1.434.g6eded367a
[PATCH 1/2] doc: fix small issues in SubmittingPatches
Signed-off-by: Kaartic Sivaraam --- Documentation/SubmittingPatches | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 558d465b6..9d0dab08d 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -293,7 +293,7 @@ then you just add a line saying Signed-off-by: Random J Developer -This line can be automatically added by Git if you run the git-commit +This line can be automatically added by Git if you run the 'git commit' command with the -s option. Notice that you can place your own Signed-off-by: line when @@ -366,7 +366,7 @@ suggests to the contributors: spend their time to improve your patch. Go back to step (2). (4) The list forms consensus that the last round of your patch is - good. Send it to the maintainer and cc the list. + good. Send it to the maintainer and cc the list. (5) A topic branch is created with the patch and is merged to 'next', and cooked further and eventually graduates to 'master'. -- 2.14.0.rc1.434.g6eded367a
