Re: [PATCH 1/2] refs: remove unused function invalidate_ref_cache

2013-10-26 Thread Michael Haggerty
On 10/26/2013 07:03 PM, Stefan Beller wrote:
> The function 'invalidate_ref_cache' was introduced in 79c7ca5 (2011-10-17,
> invalidate_ref_cache(): rename function from invalidate_cached_refs())
> by a rename and elevated to be publicly usable in 8be8bde (2011-10-17,
> invalidate_ref_cache(): expose this function in the refs API)
> 
> However it is not used anymore, as 8bf90dc (2011-10-17, write_ref_sha1():
> only invalidate the loose ref cache) and (much) later 506a760 (2013-04-22,
> refs: change how packed refs are deleted) removed any calls to this
> function. So it seems as if we don't need that function any more,
> good bye!

Looks good.  Stefan, thanks for cleaning up after me!

Michael

-- 
Michael Haggerty
mhag...@alum.mit.edu
http://softwareswirl.blogspot.com/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 1/2] refs: remove unused function invalidate_ref_cache

2013-10-26 Thread Stefan Beller
The function 'invalidate_ref_cache' was introduced in 79c7ca5 (2011-10-17,
invalidate_ref_cache(): rename function from invalidate_cached_refs())
by a rename and elevated to be publicly usable in 8be8bde (2011-10-17,
invalidate_ref_cache(): expose this function in the refs API)

However it is not used anymore, as 8bf90dc (2011-10-17, write_ref_sha1():
only invalidate the loose ref cache) and (much) later 506a760 (2013-04-22,
refs: change how packed refs are deleted) removed any calls to this
function. So it seems as if we don't need that function any more,
good bye!

Signed-off-by: Stefan Beller 
---
 refs.c | 7 ---
 refs.h | 8 
 2 files changed, 15 deletions(-)

diff --git a/refs.c b/refs.c
index 3710748..f9c1957 100644
--- a/refs.c
+++ b/refs.c
@@ -947,13 +947,6 @@ static struct ref_cache *get_ref_cache(const char 
*submodule)
return refs;
 }
 
-void invalidate_ref_cache(const char *submodule)
-{
-   struct ref_cache *refs = get_ref_cache(submodule);
-   clear_packed_ref_cache(refs);
-   clear_loose_ref_cache(refs);
-}
-
 /* The length of a peeled reference line in packed-refs, including EOL: */
 #define PEELED_LINE_LENGTH 42
 
diff --git a/refs.h b/refs.h
index b113377..87a1a79 100644
--- a/refs.h
+++ b/refs.h
@@ -165,14 +165,6 @@ extern void unlock_ref(struct ref_lock *lock);
 /** Writes sha1 into the ref specified by the lock. **/
 extern int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1, 
const char *msg);
 
-/*
- * Invalidate the reference cache for the specified submodule.  Use
- * submodule=NULL to invalidate the cache for the main module.  This
- * function must be called if references are changed via a mechanism
- * other than the refs API.
- */
-extern void invalidate_ref_cache(const char *submodule);
-
 /** Setup reflog before using. **/
 int log_ref_setup(const char *ref_name, char *logfile, int bufsize);
 
-- 
1.8.4.1.605.g23c6912

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html