[PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis
git remote show doesn't use -v/--verbose option Signed-off-by: Alexander Kuleshov --- builtin/remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/remote.c b/builtin/remote.c index 46ecfd9..978c645 100644 --- a/builtin/remote.c +++ b/builtin/remote.c @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = { N_("git remote rename "), N_("git remote remove "), N_("git remote set-head (-a | --auto | -d | --delete |)"), - N_("git remote [-v | --verbose] show [-n] "), + N_("git remote show [-n] "), N_("git remote prune [-n | --dry-run] "), N_("git remote [-v | --verbose] update [-p | --prune] [( | )...]"), N_("git remote set-branches [--add] ..."), -- 2.2.1.364.g47473d1.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis
Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov: git remote show doesn't use -v/--verbose option Hmm, but it does? $ git version git version 2.2.1 $ git remote show origin $ git remote -v show origin git://git.kernel.org/pub/scm/git/git.git (fetch) origin git://git.kernel.org/pub/scm/git/git.git (push) Perhaps you meant the following variant? The changed line documents the one above, though (-v before show). $ git remote show -v error: unknown switch `v' usage: git remote show [] -ndo not query remotes Signed-off-by: Alexander Kuleshov --- builtin/remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/remote.c b/builtin/remote.c index 46ecfd9..978c645 100644 --- a/builtin/remote.c +++ b/builtin/remote.c @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = { N_("git remote rename "), N_("git remote remove "), N_("git remote set-head (-a | --auto | -d | --delete |)"), - N_("git remote [-v | --verbose] show [-n] "), + N_("git remote show [-n] "), N_("git remote prune [-n | --dry-run] "), N_("git remote [-v | --verbose] update [-p | --prune] [( | )...]"), N_("git remote set-branches [--add] ..."), -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis
Ah, yes, right. Please dismiss 1,2 patches. Sorry for noise 2015-01-09 1:17 GMT+06:00 René Scharfe : > Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov: >> >> git remote show doesn't use -v/--verbose option > > > Hmm, but it does? > > $ git version > git version 2.2.1 > $ git remote show > origin > $ git remote -v show > origin git://git.kernel.org/pub/scm/git/git.git (fetch) > origin git://git.kernel.org/pub/scm/git/git.git (push) > > Perhaps you meant the following variant? The changed line documents the one > above, though (-v before show). > > $ git remote show -v > error: unknown switch `v' > usage: git remote show [] > > -ndo not query remotes > > >> Signed-off-by: Alexander Kuleshov >> --- >> builtin/remote.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/builtin/remote.c b/builtin/remote.c >> index 46ecfd9..978c645 100644 >> --- a/builtin/remote.c >> +++ b/builtin/remote.c >> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = { >> N_("git remote rename "), >> N_("git remote remove "), >> N_("git remote set-head (-a | --auto | -d | --delete >> |)"), >> - N_("git remote [-v | --verbose] show [-n] "), >> + N_("git remote show [-n] "), >> N_("git remote prune [-n | --dry-run] "), >> N_("git remote [-v | --verbose] update [-p | --prune] [( | >> )...]"), >> N_("git remote set-branches [--add] ..."), >> > -- _ 0xAX -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis
Alexander Kuleshov writes: > git remote show doesn't use -v/--verbose option > > Signed-off-by: Alexander Kuleshov Thanks. I think these two patches should be squashed into one (which I can do locally without asking you to resend) but they are good changes. The subcommand does not just "not use", but it does not even support (i.e. it throws an error when the option is given). > --- > builtin/remote.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/remote.c b/builtin/remote.c > index 46ecfd9..978c645 100644 > --- a/builtin/remote.c > +++ b/builtin/remote.c > @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = { > N_("git remote rename "), > N_("git remote remove "), > N_("git remote set-head (-a | --auto | -d | --delete > |)"), > - N_("git remote [-v | --verbose] show [-n] "), > + N_("git remote show [-n] "), > N_("git remote prune [-n | --dry-run] "), > N_("git remote [-v | --verbose] update [-p | --prune] [( | > )...]"), > N_("git remote set-branches [--add] ..."), -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis
René Scharfe writes: > Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov: >> git remote show doesn't use -v/--verbose option > > Hmm, but it does? > > $ git version > git version 2.2.1 > $ git remote show > origin > $ git remote -v show > origin git://git.kernel.org/pub/scm/git/git.git (fetch) > origin git://git.kernel.org/pub/scm/git/git.git (push) > > Perhaps you meant the following variant? The changed line documents > the one above, though (-v before show). > > $ git remote show -v > error: unknown switch `v' > usage: git remote show [] > > -ndo not query remotes Ahh, I misread the patch. Thanks. >> diff --git a/builtin/remote.c b/builtin/remote.c >> index 46ecfd9..978c645 100644 >> --- a/builtin/remote.c >> +++ b/builtin/remote.c >> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = { >> N_("git remote rename "), >> N_("git remote remove "), >> N_("git remote set-head (-a | --auto | -d | --delete >> |)"), >> -N_("git remote [-v | --verbose] show [-n] "), >> +N_("git remote show [-n] "), >> N_("git remote prune [-n | --dry-run] "), >> N_("git remote [-v | --verbose] update [-p | --prune] [( | >> )...]"), >> N_("git remote set-branches [--add] ..."), >> I however have a bit larger question. Does it make sense to have [-v/--verbose] in front of some but not all of the subcommands? For example, the above snippet gives me an impression that $ git remote -v prune -n origin should not work, but that does not seem to be the case. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis
What if move -v/--verbose after commands? Like: git remote show [-v | --verbose] [-n] and etc...? 2015-01-09 2:14 GMT+06:00 Junio C Hamano : > René Scharfe writes: > >> Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov: >>> git remote show doesn't use -v/--verbose option >> >> Hmm, but it does? >> >> $ git version >> git version 2.2.1 >> $ git remote show >> origin >> $ git remote -v show >> origin git://git.kernel.org/pub/scm/git/git.git (fetch) >> origin git://git.kernel.org/pub/scm/git/git.git (push) >> >> Perhaps you meant the following variant? The changed line documents >> the one above, though (-v before show). >> >> $ git remote show -v >> error: unknown switch `v' >> usage: git remote show [] >> >> -ndo not query remotes > > Ahh, I misread the patch. Thanks. > >>> diff --git a/builtin/remote.c b/builtin/remote.c >>> index 46ecfd9..978c645 100644 >>> --- a/builtin/remote.c >>> +++ b/builtin/remote.c >>> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = { >>> N_("git remote rename "), >>> N_("git remote remove "), >>> N_("git remote set-head (-a | --auto | -d | --delete >>> |)"), >>> -N_("git remote [-v | --verbose] show [-n] "), >>> +N_("git remote show [-n] "), >>> N_("git remote prune [-n | --dry-run] "), >>> N_("git remote [-v | --verbose] update [-p | --prune] [( | >>> )...]"), >>> N_("git remote set-branches [--add] ..."), >>> > > I however have a bit larger question. Does it make sense to have > [-v/--verbose] in front of some but not all of the subcommands? > > For example, the above snippet gives me an impression that > > $ git remote -v prune -n origin > > should not work, but that does not seem to be the case. -- _ 0xAX -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html