Re: [PATCH 1/2 jk/war-on-sprintf] read_branches_file: plug a FILE* leak
On Fri, Oct 23, 2015 at 08:02:51AM +0200, Johannes Sixt wrote: > The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling) > of read_branches_file() lost an fclose() call. Put it back. > > As on Windows files that are open cannot be removed, the leak manifests in > a failure of 'git remote rename origin origin' when the remote's URL is > specified in .git/branches/origin, because by the time that the command > attempts to remove this file, it is still open. Thanks for catching. This was due to my last-minute rewrite of strbuf_read_file into fopen/strbuf_getline. Your patch looks good to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2 jk/war-on-sprintf] read_branches_file: plug a FILE* leak
Johannes Sixtwrites: > The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling) > of read_branches_file() lost an fclose() call. Put it back. > > As on Windows files that are open cannot be removed, the leak manifests in > a failure of 'git remote rename origin origin' when the remote's URL is > specified in .git/branches/origin, because by the time that the command > attempts to remove this file, it is still open. > > Signed-off-by: Johannes Sixt > --- Thanks (and also for 2/2). > remote.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/remote.c b/remote.c > index 1101f82..fb16153 100644 > --- a/remote.c > +++ b/remote.c > @@ -282,6 +282,7 @@ static void read_branches_file(struct remote *remote) > return; > > strbuf_getline(, f, '\n'); > + fclose(f); > strbuf_trim(); > if (!buf.len) { > strbuf_release(); -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/2 jk/war-on-sprintf] read_branches_file: plug a FILE* leak
The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling) of read_branches_file() lost an fclose() call. Put it back. As on Windows files that are open cannot be removed, the leak manifests in a failure of 'git remote rename origin origin' when the remote's URL is specified in .git/branches/origin, because by the time that the command attempts to remove this file, it is still open. Signed-off-by: Johannes Sixt--- remote.c | 1 + 1 file changed, 1 insertion(+) diff --git a/remote.c b/remote.c index 1101f82..fb16153 100644 --- a/remote.c +++ b/remote.c @@ -282,6 +282,7 @@ static void read_branches_file(struct remote *remote) return; strbuf_getline(, f, '\n'); + fclose(f); strbuf_trim(); if (!buf.len) { strbuf_release(); -- 2.3.2.245.gb5bf9d3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html