Re: [PATCH 1/8] CodingGuidelines: typofix

2014-05-02 Thread Junio C Hamano
Jeff King p...@peff.net writes:

 On Thu, May 01, 2014 at 10:51:19AM -0700, Junio C Hamano wrote:

  If you want to fix something here, do s/judgement/judgment/ instead.
 
 That too.

 FWIW, neither is outright wrong; it is an America/British variation, and
 apparently dictionaries disagree on which is preferred.

My reading of various grammar sites was that even though variation
exists[*1*], the form without 'e' is the traditionally preferred
form, and that is why I said That too.

But let's follow this one:

http://www.google.com/trends/explore#q=judgement%20call%2C%20judgment%20callcmpt=q

which seems to say that with 'e' is more common.


[Footnote]

*1* To Americans, the form with 'e' is abomination.  Wikipedia
claims that (1) without 'e' is in legal and (2) with 'e' in other
contexts in British (this particular one is a non-legal use), and
(3) both are equally acceptable in non-legal contexts in Austraria
and Canada.


--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/8] CodingGuidelines: typofix

2014-05-02 Thread Jeff King
On Fri, May 02, 2014 at 11:31:10AM -0700, Junio C Hamano wrote:

 But let's follow this one:
 
 http://www.google.com/trends/explore#q=judgement%20call%2C%20judgment%20callcmpt=q
 
 which seems to say that with 'e' is more common.

Grammar by democracy. ;)

 *1* To Americans, the form with 'e' is abomination.  Wikipedia
 claims that (1) without 'e' is in legal and (2) with 'e' in other
 contexts in British (this particular one is a non-legal use), and
 (3) both are equally acceptable in non-legal contexts in Austraria
 and Canada.

That is what I found most interesting about the discussion. The reason I
bothered to look it up and say something is that as an American, I would
without a doubt spell it with the e, contradicting what I found
online. Oh well. 

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/8] CodingGuidelines: typofix

2014-05-02 Thread Felipe Contreras
Jeff King wrote:
 On Fri, May 02, 2014 at 11:31:10AM -0700, Junio C Hamano wrote:
 
  But let's follow this one:
  
  http://www.google.com/trends/explore#q=judgement%20call%2C%20judgment%20callcmpt=q
  
  which seems to say that with 'e' is more common.
 
 Grammar by democracy. ;)

Languages are a democracy. There's no authority that decides if
unibrow should become part of the English language. We all do.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/8] CodingGuidelines: typofix

2014-05-02 Thread David Kastrup
Felipe Contreras felipe.contre...@gmail.com writes:

 Jeff King wrote:
 On Fri, May 02, 2014 at 11:31:10AM -0700, Junio C Hamano wrote:
 
  But let's follow this one:
  
  http://www.google.com/trends/explore#q=judgement%20call%2C%20judgment%20callcmpt=q
  
  which seems to say that with 'e' is more common.
 
 Grammar by democracy. ;)

 Languages are a democracy. There's no authority that decides if
 unibrow should become part of the English language. We all do.

Well, and the U.S. justice system rather supports the hyphenation judge-
mental.

-- 
David Kastrup
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/8] CodingGuidelines: typofix

2014-05-01 Thread David Kastrup
Junio C Hamano gits...@pobox.com writes:

 The sentence lacked the necessary verb.

No, it didn't.

 Signed-off-by: Junio C Hamano gits...@pobox.com
 ---
  Documentation/CodingGuidelines | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
 index f424dbd..fdf6269 100644
 --- a/Documentation/CodingGuidelines
 +++ b/Documentation/CodingGuidelines
 @@ -15,7 +15,7 @@ code.  For Git in general, three rough rules are:
 let's use it.
  
 Again, we live in the real world, and it is sometimes a
   ^^
 -   judgement call, the decision based more on real world
 +   judgement call, the decision is based more on real world
 constraints people face than what the paper standard says.

There is one common is for original statement and paraphrase.  Adding
another one turns this into two sentences which cannot sensibly be
connected with a comma.

If you want to fix something here, do s/judgement/judgment/ instead.

-- 
David Kastrup

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/8] CodingGuidelines: typofix

2014-05-01 Thread Junio C Hamano
David Kastrup d...@gnu.org writes:

 Junio C Hamano gits...@pobox.com writes:

 The sentence lacked the necessary verb.

 No, it didn't.

 Signed-off-by: Junio C Hamano gits...@pobox.com
 ---
  Documentation/CodingGuidelines | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
 index f424dbd..fdf6269 100644
 --- a/Documentation/CodingGuidelines
 +++ b/Documentation/CodingGuidelines
 @@ -15,7 +15,7 @@ code.  For Git in general, three rough rules are:
 let's use it.
  
 Again, we live in the real world, and it is sometimes a
^^
 -   judgement call, the decision based more on real world
 +   judgement call, the decision is based more on real world
 constraints people face than what the paper standard says.

 There is one common is for original statement and paraphrase.  Adding
 another one turns this into two sentences which cannot sensibly be
 connected with a comma.

Thanks for spotting.

I thought (but I see I didn't by mistake) that I split them into two
sentences, replacing the comma with a semicolon.

 If you want to fix something here, do s/judgement/judgment/ instead.

That too.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/8] CodingGuidelines: typofix

2014-05-01 Thread Jeff King
On Thu, May 01, 2014 at 10:51:19AM -0700, Junio C Hamano wrote:

  If you want to fix something here, do s/judgement/judgment/ instead.
 
 That too.

FWIW, neither is outright wrong; it is an America/British variation, and
apparently dictionaries disagree on which is preferred.

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 1/8] CodingGuidelines: typofix

2014-04-30 Thread Junio C Hamano
The sentence lacked the necessary verb.

Signed-off-by: Junio C Hamano gits...@pobox.com
---
 Documentation/CodingGuidelines | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index f424dbd..fdf6269 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -15,7 +15,7 @@ code.  For Git in general, three rough rules are:
let's use it.
 
Again, we live in the real world, and it is sometimes a
-   judgement call, the decision based more on real world
+   judgement call, the decision is based more on real world
constraints people face than what the paper standard says.
 
 Make your code readable and sensible, and don't try to be clever.
-- 
2.0.0-rc1-355-gd6d6511

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html