[PATCH 2/7] pack-protocol.txt: Mark LF in command-list as optional
Signed-off-by: Dave Borowitz dborow...@google.com --- Documentation/technical/pack-protocol.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt index 66d2d95..1386840 100644 --- a/Documentation/technical/pack-protocol.txt +++ b/Documentation/technical/pack-protocol.txt @@ -481,7 +481,7 @@ references. shallow = PKT-LINE(shallow SP obj-id LF) command-list = PKT-LINE(command NUL capability-list LF) - *PKT-LINE(command LF) + *PKT-LINE(command LF?) flush-pkt command = create / delete / update -- 2.4.3.573.g4eafbef -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] pack-protocol.txt: Mark LF in command-list as optional
On Wed, Jul 1, 2015 at 11:08 AM, Dave Borowitz dborow...@google.com wrote: Signed-off-by: Dave Borowitz dborow...@google.com --- Documentation/technical/pack-protocol.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt index 66d2d95..1386840 100644 --- a/Documentation/technical/pack-protocol.txt +++ b/Documentation/technical/pack-protocol.txt @@ -481,7 +481,7 @@ references. shallow = PKT-LINE(shallow SP obj-id LF) command-list = PKT-LINE(command NUL capability-list LF) We may also want to mark it in this line above as well as in the shallow line? I think the problem with this part of the documentation is its ambiguity on what exactly we want to document. The sender SHOULD put an LF, while the receiver MUST NOT assume the LF is there always, so I guess it's best to mark it optional from a receivers point of view. - *PKT-LINE(command LF) + *PKT-LINE(command LF?) flush-pkt command = create / delete / update -- 2.4.3.573.g4eafbef -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] pack-protocol.txt: Mark LF in command-list as optional
On Wed, Jul 1, 2015 at 11:21 AM, Stefan Beller sbel...@google.com wrote: I think the problem with this part of the documentation is its ambiguity on what exactly we want to document. The sender SHOULD put an LF, while the receiver MUST NOT assume the LF is there always, so I guess it's best to mark it optional from a receivers point of view. To be clear, this patch is a partial fix to one particular spec in the file. See 1/7 for the general warning not to trust these. Auditing the file completely was not the goal of this series. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html