Re: [PATCH 2/8] ewah/bitmap.c: delete unused 'bitmap_each_bit()'

[Ramsay Jones]

On 15/06/18 15:30, Derrick Stolee wrote:
> Reported-by: Ramsay Jones 
> Signed-off-by: Derrick Stolee 
> ---
>  ewah/bitmap.c | 24 
>  1 file changed, 24 deletions(-)
> 
> diff --git a/ewah/bitmap.c b/ewah/bitmap.c
> index d61dc6114a..52f1178db4 100644
> --- a/ewah/bitmap.c
> +++ b/ewah/bitmap.c
> @@ -129,30 +129,6 @@ void bitmap_or_ewah(struct bitmap *self, struct 
> ewah_bitmap *other)
>   self->words[i++] |= word;
>  }
>  
> -void bitmap_each_bit(struct bitmap *self, ewah_callback callback, void *data)
> -{
> - size_t pos = 0, i;
> -
> - for (i = 0; i < self->word_alloc; ++i) {
> - eword_t word = self->words[i];
> - uint32_t offset;
> -
> - if (word == (eword_t)~0) {
> - for (offset = 0; offset < BITS_IN_EWORD; ++offset)
> - callback(pos++, data);
> - } else {
> - for (offset = 0; offset < BITS_IN_EWORD; ++offset) {
> - if ((word >> offset) == 0)
> - break;
> -
> - offset += ewah_bit_ctz64(word >> offset);
> - callback(pos + offset, data);
> - }
> - pos += BITS_IN_EWORD;
> - }
> - }
> -}
> -
>  size_t bitmap_popcount(struct bitmap *self)
>  {
>   size_t i, count = 0;
> 

Again, remove extern declaration from header file.

ATB,
Ramsay Jones

[PATCH 2/8] ewah/bitmap.c: delete unused 'bitmap_each_bit()'

[Derrick Stolee]

Reported-by: Ramsay Jones 
Signed-off-by: Derrick Stolee 
---
 ewah/bitmap.c | 24 
 1 file changed, 24 deletions(-)

diff --git a/ewah/bitmap.c b/ewah/bitmap.c
index d61dc6114a..52f1178db4 100644
--- a/ewah/bitmap.c
+++ b/ewah/bitmap.c
@@ -129,30 +129,6 @@ void bitmap_or_ewah(struct bitmap *self, struct 
ewah_bitmap *other)
self->words[i++] |= word;
 }
 
-void bitmap_each_bit(struct bitmap *self, ewah_callback callback, void *data)
-{
-   size_t pos = 0, i;
-
-   for (i = 0; i < self->word_alloc; ++i) {
-   eword_t word = self->words[i];
-   uint32_t offset;
-
-   if (word == (eword_t)~0) {
-   for (offset = 0; offset < BITS_IN_EWORD; ++offset)
-   callback(pos++, data);
-   } else {
-   for (offset = 0; offset < BITS_IN_EWORD; ++offset) {
-   if ((word >> offset) == 0)
-   break;
-
-   offset += ewah_bit_ctz64(word >> offset);
-   callback(pos + offset, data);
-   }
-   pos += BITS_IN_EWORD;
-   }
-   }
-}
-
 size_t bitmap_popcount(struct bitmap *self)
 {
size_t i, count = 0;
-- 
2.18.0.rc1