Re: [PATCH 5/9] t1300: `--unset-all` can leave an empty section behind (bug)
On Thu, Mar 29, 2018 at 05:18:53PM +0200, Johannes Schindelin wrote: > We already have a test demonstrating that removing the last entry from a > config section fails to remove the section header of the now-empty > section. > > The same can happen, of course, if we remove the last entries in one fell > swoop. This is *also* a bug, and should be fixed at the same time. Yep, makes sense, and the diff is obviously correct. -Peff
[PATCH 5/9] t1300: `--unset-all` can leave an empty section behind (bug)
We already have a test demonstrating that removing the last entry from a config section fails to remove the section header of the now-empty section. The same can happen, of course, if we remove the last entries in one fell swoop. This is *also* a bug, and should be fixed at the same time. Signed-off-by: Johannes Schindelin --- t/t1300-config.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 3ad3df0c83e..ff79a213567 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1452,6 +1452,17 @@ test_expect_failure '--unset last key removes section (except if commented)' ' test_cmp expect .git/config ' +test_expect_failure '--unset-all removes section if empty & uncommented' ' + cat >.git/config <<-\EOF && + [section] + key = value1 + key = value2 + EOF + + git config --unset-all section.key && + test_line_count = 0 .git/config +' + test_expect_failure 'adding a key into an empty section reuses header' ' cat >.git/config <<-\EOF && [section] -- 2.16.2.windows.1.26.g2cc3565eb4b
