Re: [PATCH v1 0/2] contrib/subtree: make it respect spaces in a repository path
On Fri, Sep 04, 2015 at 04:08:06PM -0700, Junio C Hamano wrote: > Alexey Shumkinwrites: > > > Some repositories may have spaces in their paths. Currently `git-subtree` > > raises an error in such cases. > > Also, `git-subtree` currently does not have tests for its 'push' command. > > Following patches are to fix these statements. > > > > Alexey Shumkin (2): > > t7900-subtree: test the "space in a subdirectory name" case > > contrib/subtree: respect spaces in a repository path > > Doesn't this order break bisection? It seems that you turn "subdir" > to "sub dir" in existing tests, and I understand that the whole > point of this series is that such a change will expose that the tool > is broken, making tests fail. It seems I have to reword commit messages to avoid such an interpretation. Because, the first commit does not break anything. It is to change the tests for `git-subtree` "to show" that `git-subtree`s already tested commands (almost) work correctly if there are spaces in paths (except --rejoin-msg issue). And the second commit adds missing tests and the fix. Should I add/commit the breaking test first and then commit the fix? > > Also, if you feel up to it, it might be a good idea to clean t7900 > test up to the current best practice before doing any other changes > as a pure preparatory clean-up patch. > > Namely, using cd outside a subshell of the tests to move around is a > bad thing to do, and you are adding more instance of it in this > series. If one test with such a cd to go down fails before it has a > chance to come back up (or go up and then fail to come back down), > the later tests will be left in an unexpected place. I understand this issue with "cd" (I've just followed the existing t7900 tests "code style"). > > > contrib/subtree/git-subtree.sh | 4 +- > > contrib/subtree/t/t7900-subtree.sh | 194 > > +++-- > > 2 files changed, 124 insertions(+), 74 deletions(-) > > Thanks. -- Alexey Shumkin E-mail: alex.crez...@gmail.com ICQ: 118001447 Jabber (GoogleTalk): alex.crez...@gmail.com Skype: crezoff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 0/2] contrib/subtree: make it respect spaces in a repository path
Alexey Shumkinwrites: > Some repositories may have spaces in their paths. Currently `git-subtree` > raises an error in such cases. > Also, `git-subtree` currently does not have tests for its 'push' command. > Following patches are to fix these statements. > > Alexey Shumkin (2): > t7900-subtree: test the "space in a subdirectory name" case > contrib/subtree: respect spaces in a repository path Doesn't this order break bisection? It seems that you turn "subdir" to "sub dir" in existing tests, and I understand that the whole point of this series is that such a change will expose that the tool is broken, making tests fail. Also, if you feel up to it, it might be a good idea to clean t7900 test up to the current best practice before doing any other changes as a pure preparatory clean-up patch. Namely, using cd outside a subshell of the tests to move around is a bad thing to do, and you are adding more instance of it in this series. If one test with such a cd to go down fails before it has a chance to come back up (or go up and then fail to come back down), the later tests will be left in an unexpected place. > contrib/subtree/git-subtree.sh | 4 +- > contrib/subtree/t/t7900-subtree.sh | 194 > +++-- > 2 files changed, 124 insertions(+), 74 deletions(-) Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v1 0/2] contrib/subtree: make it respect spaces in a repository path
Some repositories may have spaces in their paths. Currently `git-subtree` raises an error in such cases. Also, `git-subtree` currently does not have tests for its 'push' command. Following patches are to fix these statements. Alexey Shumkin (2): t7900-subtree: test the "space in a subdirectory name" case contrib/subtree: respect spaces in a repository path contrib/subtree/git-subtree.sh | 4 +- contrib/subtree/t/t7900-subtree.sh | 194 +++-- 2 files changed, 124 insertions(+), 74 deletions(-) -- 2.4.1-21 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html