Re: [PATCH v2 0/9] X509 (gpgsm) commit signing support
On Sat, Jul 14, 2018 at 06:33:12PM +, brian m. carlson wrote: > > This series is a fine replacement for that earlier work. It's flexible > > enough to allow what we really wanted out of that series (gpgsm support, > > or another drop-in tool that uses the same interface). It doesn't lay > > any groundwork for further tools (like signify), but I think the > > consensus on the list was to punt on that until somebody had more > > concrete plans for adding such a tool. > > I actually think this moves in a nice direction for adding support for > minisign/signify and other schemes. There's a way to look up what > algorithm is in use in a particular context based on the first line and > a general interface for deciding what format to write. Granted, it > currently still is very specific to gpg-style tools, but I think this is > an improvement in that regard. My issue with this for helping with signify is that it creates a new gpg..* hierarchy with two slots (openpgp and x509). But we would not want gpg.signify.program, would we? That makes no sense, as neither the signature-matching nor the program invocation are gpg-like. But if we later moved to "signingtool..*", now we have an extra layer of compatibility to deal with. E.g., signingtool.openpgp.program is the same as gpg.openpgp.program which is the same as gpg.program. I think we can do that, but it means more historical baggage. I'm OK with that since signify support is purely hypothetical at this point. But that's why I say that this doesn't lay the groundwork in the way that the other series did. > As an OpenPGP user, I have no interest in adding support for other > tools, but I think this should make it easier if someone else wants to > do that. I don't plan to work on signify (or other tools) anytime soon either. My interest here is in x509, since that's what enterprises would use over pgp. I actually dislike pgp for this application, too, because I find the key management kind of complicated and tedious. But at least it's a standard among open source folks. -Peff
Re: [PATCH v2 0/9] X509 (gpgsm) commit signing support
On Tue, Jul 10, 2018 at 01:12:24PM -0400, Jeff King wrote: > On Tue, Jul 10, 2018 at 10:52:22AM +0200, Henning Schild wrote: > > This series can be seen as a follow up of a series that appeared under > > the name "gpg-interface: Multiple signing tools" in april 2018 [1]. After > > that series was not merged i decided to get my patches ready. The > > original series aimed at being generic for any sort of signing tool, while > > this series just introduced the X509 variant of gpg. (gpgsm) > > I collected authors and reviewers of that first series and already put them > > on cc. > > This series is a fine replacement for that earlier work. It's flexible > enough to allow what we really wanted out of that series (gpgsm support, > or another drop-in tool that uses the same interface). It doesn't lay > any groundwork for further tools (like signify), but I think the > consensus on the list was to punt on that until somebody had more > concrete plans for adding such a tool. I actually think this moves in a nice direction for adding support for minisign/signify and other schemes. There's a way to look up what algorithm is in use in a particular context based on the first line and a general interface for deciding what format to write. Granted, it currently still is very specific to gpg-style tools, but I think this is an improvement in that regard. As an OpenPGP user, I have no interest in adding support for other tools, but I think this should make it easier if someone else wants to do that. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204 signature.asc Description: PGP signature
Re: [PATCH v2 0/9] X509 (gpgsm) commit signing support
On Tue, Jul 10, 2018 at 10:52:22AM +0200, Henning Schild wrote: > This series adds support for signing commits with gpgsm. Thanks for working on this. I left a bunch of comments, but overall the direction looks good. We talked about this a bit off-list, but just for the public record: > This series can be seen as a follow up of a series that appeared under > the name "gpg-interface: Multiple signing tools" in april 2018 [1]. After > that series was not merged i decided to get my patches ready. The > original series aimed at being generic for any sort of signing tool, while > this series just introduced the X509 variant of gpg. (gpgsm) > I collected authors and reviewers of that first series and already put them > on cc. This series is a fine replacement for that earlier work. It's flexible enough to allow what we really wanted out of that series (gpgsm support, or another drop-in tool that uses the same interface). It doesn't lay any groundwork for further tools (like signify), but I think the consensus on the list was to punt on that until somebody had more concrete plans for adding such a tool. -Peff
[PATCH v2 0/9] X509 (gpgsm) commit signing support
Changes in v2: - removed trailing commas in array initializers and add leading space - replaced assert(0) with BUG in p5 - consolidated 2 format lookups reusing get_format_data p5 - changed from format "PGP" to "openpgp", later X509 to "x509" - use strcasecmp instead of strcmp for format matching - introduce gpg..program in p8, no gpg.programX509 anymore - moved t/7510 patch inbetween the two patches changing validation code - changed t/7510 patch to use test_config and test_must_fail This series adds support for signing commits with gpgsm. The first two patches are cleanups of gpg-interface, they are already close to being merged. But since they have not been pulled to next i am resending them. The following 5 patches (p3-p7) prepare for the introduction of the actual feature in patch 8. Finally patch 9 extends the testsuite to cover the new feature. This series can be seen as a follow up of a series that appeared under the name "gpg-interface: Multiple signing tools" in april 2018 [1]. After that series was not merged i decided to get my patches ready. The original series aimed at being generic for any sort of signing tool, while this series just introduced the X509 variant of gpg. (gpgsm) I collected authors and reviewers of that first series and already put them on cc. [1] https://public-inbox.org/git/20180409204129.43537-1-mastahy...@gmail.com/ Henning Schild (9): builtin/receive-pack: use check_signature from gpg-interface gpg-interface: make parse_gpg_output static and remove from interface header gpg-interface: add new config to select how to sign a commit t/t7510: check the validation of the new config gpg.format gpg-interface: introduce an abstraction for multiple gpg formats gpg-interface: do not hardcode the key string len anymore gpg-interface: introduce new config to select per gpg format program gpg-interface: introduce new signature format "x509" using gpgsm gpg-interface t: extend the existing GPG tests with GPGSM Documentation/config.txt | 9 + builtin/receive-pack.c | 17 ++--- gpg-interface.c| 88 ++ gpg-interface.h| 2 -- t/lib-gpg.sh | 9 - t/lib-gpg/gpgsm-gen-key.in | 6 t/t4202-log.sh | 66 ++ t/t5534-push-signed.sh | 52 +++ t/t7003-filter-branch.sh | 15 t/t7030-verify-tag.sh | 47 +++-- t/t7510-signed-commit.sh | 10 ++ t/t7600-merge.sh | 31 12 files changed, 317 insertions(+), 35 deletions(-) create mode 100644 t/lib-gpg/gpgsm-gen-key.in -- 2.16.4
