Re: [PATCH v2 00/31] object-store: lookup_commit
On 06/13, Stefan Beller wrote: > * removed mentions of cooci patches > * added forward declaration of commit buffer slabs. > * dropped 3 patches that add the repository to lookup_unkonwn_object, > parse_commit and parse_commit_gently, but were not converting those > functions. We'll convert these in the next series, as this series is > growing big already. > * This series can be found as branch 'object-store-lookup-commit' on github, > it applies on top of nd/commit-util-to-slab merged with > sb/object-store-grafts > > v1, https://public-inbox.org/git/20180530004810.30076-1-sbel...@google.com/ > > This applies on the merge of nd/commit-util-to-slab and > sb/object-store-grafts, > and is available at http://github.com/stefanbeller/ as branch > object-store-lookup-commit > as the merge has some merge conflicts as well as syntactical conflicts > (upload-pack.c > and fetch-pack.c introduce new calls of functions that would want to take a > repository struct > in the object-store-grafts series) > > As layed out in > https://public-inbox.org/git/20180517225154.9200-1-sbel...@google.com/ > this is getting close to finishing the set of object store series though the > last > unfinished part of this RFC hints at new work on the plate: > * To give this series a nice polish, we'd want to convert parse_commit, too. > But that requires the conversion of the new commit graph. Maybe we need > to split this series into 2. > * Once this is in good shape we can talk about converting parts of the > revision > walking code, > * which then can be used by the submodule code as the end goal for the > object store series. I've taken a look at the series and it looks good. I'm glad we're getting closer to this set of series being completed. Thanks for pushing this through :) -- Brandon Williams
Re: [PATCH v2 00/31] object-store: lookup_commit
On Thu, Jun 14, 2018 at 1:08 AM Stefan Beller wrote: > > * removed mentions of cooci patches > * added forward declaration of commit buffer slabs. > * dropped 3 patches that add the repository to lookup_unkonwn_object, > parse_commit and parse_commit_gently, but were not converting those > functions. We'll convert these in the next series, as this series is > growing big already. > * This series can be found as branch 'object-store-lookup-commit' on github, > it applies on top of nd/commit-util-to-slab merged with > sb/object-store-grafts > > v1, https://public-inbox.org/git/20180530004810.30076-1-sbel...@google.com/ > > This applies on the merge of nd/commit-util-to-slab and > sb/object-store-grafts, > and is available at http://github.com/stefanbeller/ as branch > object-store-lookup-commit I only looked at whole-series diff, not individual patches (sorry). Besides the one comment I made elsewhere, it looks good. You don't even need to reroll this series to address that one. A follow up patch whenever you feel like it is fine, or I'll get to it eventually (after the_index is gone, I plan to kill the_repository outside builtin/ too, for the same reason). -- Duy
Re: [PATCH v2 00/31] object-store: lookup_commit
On 6/13/2018 9:23 PM, Derrick Stolee wrote: On 6/13/2018 7:04 PM, Stefan Beller wrote * Once this is in good shape we can talk about converting parts of the revision walking code, This is another reason why I'll be waiting for this series of series. I plan to rework the revision walking code around sort_in_topological_order(), but I'll wait for your changes to land before submitting a patch. I'm itching to play with it, so I may start testing things out before then. In the meantime, I'll do my part by reviewing the current series. Looks good to me. Reviewed-by: Derrick Stolee
Re: [PATCH v2 00/31] object-store: lookup_commit
On 6/13/2018 7:04 PM, Stefan Beller wrote * Once this is in good shape we can talk about converting parts of the revision walking code, This is another reason why I'll be waiting for this series of series. I plan to rework the revision walking code around sort_in_topological_order(), but I'll wait for your changes to land before submitting a patch. I'm itching to play with it, so I may start testing things out before then. In the meantime, I'll do my part by reviewing the current series. Thanks, -Stolee
[PATCH v2 00/31] object-store: lookup_commit
* removed mentions of cooci patches * added forward declaration of commit buffer slabs. * dropped 3 patches that add the repository to lookup_unkonwn_object, parse_commit and parse_commit_gently, but were not converting those functions. We'll convert these in the next series, as this series is growing big already. * This series can be found as branch 'object-store-lookup-commit' on github, it applies on top of nd/commit-util-to-slab merged with sb/object-store-grafts v1, https://public-inbox.org/git/20180530004810.30076-1-sbel...@google.com/ This applies on the merge of nd/commit-util-to-slab and sb/object-store-grafts, and is available at http://github.com/stefanbeller/ as branch object-store-lookup-commit as the merge has some merge conflicts as well as syntactical conflicts (upload-pack.c and fetch-pack.c introduce new calls of functions that would want to take a repository struct in the object-store-grafts series) As layed out in https://public-inbox.org/git/20180517225154.9200-1-sbel...@google.com/ this is getting close to finishing the set of object store series though the last unfinished part of this RFC hints at new work on the plate: * To give this series a nice polish, we'd want to convert parse_commit, too. But that requires the conversion of the new commit graph. Maybe we need to split this series into 2. * Once this is in good shape we can talk about converting parts of the revision walking code, * which then can be used by the submodule code as the end goal for the object store series. Thanks, Stefan Stefan Beller (31): object: add repository argument to lookup_object object: add repository argument to parse_object_buffer object: add repository argument to object_as_type blob: add repository argument to lookup_blob tree: add repository argument to lookup_tree commit: add repository argument to lookup_commit_reference_gently commit: add repository argument to lookup_commit_reference commit: add repository argument to lookup_commit commit: add repository argument to parse_commit_buffer commit: add repository argument to set_commit_buffer commit: add repository argument to get_cached_commit_buffer tag: add repository argument to lookup_tag tag: add repository argument to parse_tag_buffer tag: add repository argument to deref_tag object: allow object_as_type to handle arbitrary repositories object: allow lookup_object to handle arbitrary repositories blob: allow lookup_blob to handle arbitrary repositories tree: allow lookup_tree to handle arbitrary repositories commit: allow lookup_commit to handle arbitrary repositories tag: allow lookup_tag to handle arbitrary repositories tag: allow parse_tag_buffer to handle arbitrary repositories commit.c: allow parse_commit_buffer to handle arbitrary repositories commit-slabs: remove realloc counter outside of slab struct commit.c: migrate the commit buffer to the parsed object store commit.c: allow set_commit_buffer to handle arbitrary repositories commit.c: allow get_cached_commit_buffer to handle arbitrary repositories object.c: allow parse_object_buffer to handle arbitrary repositories object.c: allow parse_object to handle arbitrary repositories tag.c: allow deref_tag to handle arbitrary repositories commit.c: allow lookup_commit_reference_gently to handle arbitrary repositories commit.c: allow lookup_commit_reference to handle arbitrary repositories archive.c| 2 +- bisect.c | 2 +- blame.c | 13 +++ blob.c | 10 +++--- blob.h | 2 +- branch.c | 2 +- builtin/am.c | 9 +++-- builtin/branch.c | 7 ++-- builtin/checkout.c | 6 ++-- builtin/clone.c | 3 +- builtin/commit-tree.c| 4 ++- builtin/describe.c | 13 +++ builtin/diff-tree.c | 6 ++-- builtin/diff.c | 5 +-- builtin/fast-export.c| 12 --- builtin/fetch.c | 9 +++-- builtin/fmt-merge-msg.c | 5 +-- builtin/fsck.c | 16 + builtin/grep.c | 3 +- builtin/index-pack.c | 5 +-- builtin/log.c| 7 ++-- builtin/merge-base.c | 7 ++-- builtin/merge-tree.c | 3 +- builtin/name-rev.c | 6 ++-- builtin/notes.c | 3 +- builtin/pack-objects.c | 2 +- builtin/prune.c | 2 +- builtin/pull.c | 15 +--- builtin/reflog.c | 12 --- builtin/replace.c| 4 +-- builtin/reset.c | 4 +-- builtin/rev-parse.c | 6 ++-- builtin/show-branch.c| 5 +-- builtin/tag.c| 2 +- builtin/unpack-objects.c | 7 ++-- builtin/verify-commit.c | 4 ++- bundle.c | 5 +-- cache-tree.c | 3 +- commit-graph.c | 14 commit-slab-impl.h | 3 -- commit.c | 77 +--- commit.h
