Re: [PATCH v2 00/37] removal of some c++ keywords

2018-02-14 Thread Stefan Beller
On Wed, Feb 14, 2018 at 10:59 AM, Brandon Williams  wrote:
> One person was interested enough for me to go back through and also
> rename all the paired 'old' variables to match the new names for the
> variables which were named 'new'.

The patches are:
Reviewed-by: Stefan Beller 
(apart from the 'this' nit Junio had)


[PATCH v2 00/37] removal of some c++ keywords

2018-02-14 Thread Brandon Williams
One person was interested enough for me to go back through and also
rename all the paired 'old' variables to match the new names for the
variables which were named 'new'.

Brandon Williams (37):
  object_info: change member name from 'typename' to 'type_name'
  object: rename function 'typename' to 'type_name'
  blame: rename 'this' variables
  pack-objects: rename 'this' variables
  rev-parse: rename 'this' variable
  diff: rename 'this' variables
  apply: rename 'try' variables
  apply: rename 'new' variables
  checkout: rename 'new' variables
  help: rename 'new' variables
  pack-redundant: rename 'new' variables
  reflog: rename 'new' variables
  remote: rename 'new' variables
  combine-diff: rename 'new' variables
  commit: rename 'new' variables
  diff-lib: rename 'new' variable
  diff: rename 'new' variables
  diffcore-delta: rename 'new' variables
  entry: rename 'new' variables
  http: rename 'new' variables
  imap-send: rename 'new' variables
  line-log: rename 'new' variables
  read-cache: rename 'new' variables
  ref-filter: rename 'new' variables
  remote: rename 'new' variables
  split-index: rename 'new' variables
  submodule: rename 'new' variables
  trailer: rename 'new' variables
  unpack-trees: rename 'new' variables
  init-db: rename 'template' variables
  environment: rename 'template' variables
  diff: rename 'template' variables
  environment: rename 'namespace' variables
  wrapper: rename 'template' variables
  tempfile: rename 'template' variables
  trailer: rename 'template' variables
  replace: rename 'new' variables

 apply.c| 122 +++
 blame.c|  33 +++--
 builtin/cat-file.c |   4 +-
 builtin/checkout.c | 196 -
 builtin/diff-tree.c|   2 +-
 builtin/fast-export.c  |   8 +-
 builtin/fsck.c |   4 +-
 builtin/grep.c |   2 +-
 builtin/help.c |  10 +-
 builtin/index-pack.c   |  12 +-
 builtin/init-db.c  |  30 ++--
 builtin/merge.c|   2 +-
 builtin/mktree.c   |   4 +-
 builtin/pack-objects.c |   8 +-
 builtin/pack-redundant.c   |  54 +++
 builtin/prune.c|   2 +-
 builtin/reflog.c   |   8 +-
 builtin/remote.c   |  66 -
 builtin/replace.c  |  46 +++---
 builtin/rev-parse.c|  34 ++---
 builtin/tag.c  |   2 +-
 builtin/unpack-objects.c   |  10 +-
 builtin/verify-commit.c|   2 +-
 bulk-checkin.c |   2 +-
 cache.h|   4 +-
 combine-diff.c |  12 +-
 commit.c   |  20 +--
 contrib/examples/builtin-fetch--tool.c |   2 +-
 diff-lib.c |  38 ++---
 diff.c |  62 
 diffcore-delta.c   |  16 +-
 entry.c|  40 ++---
 environment.c  |  24 +--
 fast-import.c  |  16 +-
 fsck.c |   2 +-
 git-compat-util.h  |   4 +-
 http-push.c|   2 +-
 http.c |  10 +-
 imap-send.c|  14 +-
 line-log.c |  56 +++
 log-tree.c |   2 +-
 object.c   |   6 +-
 object.h   |   2 +-
 pack-check.c   |   2 +-
 packfile.c |   8 +-
 reachable.c|   2 +-
 read-cache.c   |  40 ++---
 ref-filter.c   |  20 +--
 remote.c   |  20 +--
 sequencer.c|   2 +-
 sha1_file.c|  28 ++--
 sha1_name.c|   6 +-
 split-index.c  |  16 +-
 split-index.h  |   2 +-
 submodule.c|  32 ++--
 submodule.h|   2 +-
 tag.c  |   2 +-
 tempfile.c |  12 +-
 tempfile.h |  34 ++---
 trailer.c  |  44 +++---
 unpack-trees.c |   6 +-
 walker.c   |   4 +-
 wrapper.c  |  40 ++---
 63 files changed, 659 insertions(+), 658 deletions(-)

-- 
2.16.1.291.g4437f3f132-goog