Re: [PATCH v2 1/2] rebase -i: clarify what happens on a failed `exec`

2018-10-12 Thread Johannes Schindelin
Hi Junio & Eric,

On Thu, 11 Oct 2018, Junio C Hamano wrote:

> Eric Sunshine  writes:
> 
> > On Wed, Oct 10, 2018 at 4:54 AM Johannes Schindelin via GitGitGadget
> >  wrote:
> >> We had not documented previously what happens when an `exec` command in
> >> an interactive rebase fails. Now we do.
> >>
> >> Signed-off-by: Johannes Schindelin 
> >> ---
> >> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
> >> @@ -420,7 +420,8 @@ idea unless you know what you are doing (see BUGS 
> >> below).
> >>  --exec ::
> >> Append "exec " after each line creating a commit in the
> >> final history.  will be interpreted as one or more shell
> >> -   commands.
> >> +   commands. Anz command that fails will interrupt the rebase,
> >> +   withe exit code 1.
> >
> > s/Anz/Any/
> > s/withe/with/

These tyopes will be fxied in the nxet itaretion.

Ciao,
Dhsco

> 
> Heh, I know I am not good at spelling, either, but hopefully I am a
> bit more careful than leaving as many typoes as I have added lines
> in my patch X-<.  After all, it's not a race to send in patches as
> quickly as possible.
> 
> Queued.  Thanks, both.
> 


Re: [PATCH v2 1/2] rebase -i: clarify what happens on a failed `exec`

2018-10-11 Thread Junio C Hamano
Eric Sunshine  writes:

> On Wed, Oct 10, 2018 at 4:54 AM Johannes Schindelin via GitGitGadget
>  wrote:
>> We had not documented previously what happens when an `exec` command in
>> an interactive rebase fails. Now we do.
>>
>> Signed-off-by: Johannes Schindelin 
>> ---
>> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
>> @@ -420,7 +420,8 @@ idea unless you know what you are doing (see BUGS below).
>>  --exec ::
>> Append "exec " after each line creating a commit in the
>> final history.  will be interpreted as one or more shell
>> -   commands.
>> +   commands. Anz command that fails will interrupt the rebase,
>> +   withe exit code 1.
>
> s/Anz/Any/
> s/withe/with/

Heh, I know I am not good at spelling, either, but hopefully I am a
bit more careful than leaving as many typoes as I have added lines
in my patch X-<.  After all, it's not a race to send in patches as
quickly as possible.

Queued.  Thanks, both.


Re: [PATCH v2 1/2] rebase -i: clarify what happens on a failed `exec`

2018-10-10 Thread Eric Sunshine
On Wed, Oct 10, 2018 at 4:54 AM Johannes Schindelin via GitGitGadget
 wrote:
> We had not documented previously what happens when an `exec` command in
> an interactive rebase fails. Now we do.
>
> Signed-off-by: Johannes Schindelin 
> ---
> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
> @@ -420,7 +420,8 @@ idea unless you know what you are doing (see BUGS below).
>  --exec ::
> Append "exec " after each line creating a commit in the
> final history.  will be interpreted as one or more shell
> -   commands.
> +   commands. Anz command that fails will interrupt the rebase,
> +   withe exit code 1.

s/Anz/Any/
s/withe/with/


[PATCH v2 1/2] rebase -i: clarify what happens on a failed `exec`

2018-10-10 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin 

We had not documented previously what happens when an `exec` command in
an interactive rebase fails. Now we do.

Signed-off-by: Johannes Schindelin 
---
 Documentation/git-rebase.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
index 091eb53faa..db2faca73c 100644
--- a/Documentation/git-rebase.txt
+++ b/Documentation/git-rebase.txt
@@ -420,7 +420,8 @@ idea unless you know what you are doing (see BUGS below).
 --exec ::
Append "exec " after each line creating a commit in the
final history.  will be interpreted as one or more shell
-   commands.
+   commands. Anz command that fails will interrupt the rebase,
+   withe exit code 1.
 +
 You may execute several commands by either using one instance of `--exec`
 with several commands:
-- 
gitgitgadget