Re: [PATCH v2 1/7] gitk: support -G option from the command line

2013-10-30 Thread Thomas Rast
Junio C Hamano gits...@pobox.com writes:

 Thomas Rast t...@thomasrast.ch writes:

 From: Thomas Rast tr...@inf.ethz.ch

 The -G option's usage is exactly analogous to that of -S, so
 supporting it is easy.

 Signed-off-by: Thomas Rast tr...@inf.ethz.ch
 ---
  gitk-git/gitk | 2 +-

 You CC'ed Paul, which is absolutely the right thing to do, but
 please make patches against his tree, which does not have gitk-git/
 directory at the top-level.

I figured this was easier on potential testers.  As outlined in the
cover letter, I'll do the splitting and rebasing later.

-- 
Thomas Rast
t...@thomasrast.ch
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 1/7] gitk: support -G option from the command line

2013-10-30 Thread Junio C Hamano
Thomas Rast t...@thomasrast.ch writes:

 I figured this was easier on potential testers.  As outlined in the
 cover letter, I'll do the splitting and rebasing later.

Sorry, I should have read 0/7 before responding, but the message
came out of order.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 1/7] gitk: support -G option from the command line

2013-10-29 Thread Thomas Rast
From: Thomas Rast tr...@inf.ethz.ch

The -G option's usage is exactly analogous to that of -S, so
supporting it is easy.

Signed-off-by: Thomas Rast tr...@inf.ethz.ch
---
 gitk-git/gitk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index 5cd00d8..0e95814 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -227,7 +227,7 @@ proc parseviewargs {n arglist} {
--until=* - --before=* - --max-age=* - --min-age=* -
--author=* - --committer=* - --grep=* - -[iE] -
--remove-empty - --first-parent - --cherry-pick -
-   -S* - --pickaxe-all - --pickaxe-regex -
+   -S* - -G* - --pickaxe-all - --pickaxe-regex -
--simplify-by-decoration {
# These mean that we get a subset of the commits
set filtered 1
-- 
1.8.4.2.838.ga9a3e20

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 1/7] gitk: support -G option from the command line

2013-10-29 Thread Junio C Hamano
Thomas Rast t...@thomasrast.ch writes:

 From: Thomas Rast tr...@inf.ethz.ch

 The -G option's usage is exactly analogous to that of -S, so
 supporting it is easy.

 Signed-off-by: Thomas Rast tr...@inf.ethz.ch
 ---
  gitk-git/gitk | 2 +-

You CC'ed Paul, which is absolutely the right thing to do, but
please make patches against his tree, which does not have gitk-git/
directory at the top-level.

I think the patch itself makes sense.

Thanks.

  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/gitk-git/gitk b/gitk-git/gitk
 index 5cd00d8..0e95814 100755
 --- a/gitk-git/gitk
 +++ b/gitk-git/gitk
 @@ -227,7 +227,7 @@ proc parseviewargs {n arglist} {
   --until=* - --before=* - --max-age=* - --min-age=* -
   --author=* - --committer=* - --grep=* - -[iE] -
   --remove-empty - --first-parent - --cherry-pick -
 - -S* - --pickaxe-all - --pickaxe-regex -
 + -S* - -G* - --pickaxe-all - --pickaxe-regex -
   --simplify-by-decoration {
   # These mean that we get a subset of the commits
   set filtered 1
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html