Re: [PATCH v2 13/41] completion: use __gitcomp_builtin in _git_commit

2018-01-31 Thread Eric Sunshine
On Wed, Jan 31, 2018 at 6:05 AM, Nguyễn Thái Ngọc Duy  wrote:
> The new comletable options are:

s/comletable/completable/

> --branch
> --gpg-sign
> --long
> --no-post-rewrite
> --null
> --porcelain
> --status
>
> --allow-empty is no longer completable because it's a hidden option
> since 4741edd549 (Remove deprecated OPTION_BOOLEAN for parsing arguments
> - 2013-08-03)
>
> Signed-off-by: Nguyễn Thái Ngọc Duy 


[PATCH v2 13/41] completion: use __gitcomp_builtin in _git_commit

2018-01-31 Thread Nguyễn Thái Ngọc Duy
The new comletable options are:

--branch
--gpg-sign
--long
--no-post-rewrite
--null
--porcelain
--status

--allow-empty is no longer completable because it's a hidden option
since 4741edd549 (Remove deprecated OPTION_BOOLEAN for parsing arguments
- 2013-08-03)

Signed-off-by: Nguyễn Thái Ngọc Duy 
---
 contrib/completion/git-completion.bash | 11 +--
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/contrib/completion/git-completion.bash 
b/contrib/completion/git-completion.bash
index 393f86619d..8bbe94a94f 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1339,16 +1339,7 @@ _git_commit ()
return
;;
--*)
-   __gitcomp "
-   --all --author= --signoff --verify --no-verify
-   --edit --no-edit
-   --amend --include --only --interactive
-   --dry-run --reuse-message= --reedit-message=
-   --reset-author --file= --message= --template=
-   --cleanup= --untracked-files --untracked-files=
-   --verbose --quiet --fixup= --squash=
-   --patch --short --date --allow-empty
-   "
+   __gitcomp_builtin commit "--no-edit --verify"
return
esac
 
-- 
2.16.1.205.g271f633410