Re: [PATCH v2 16/23] worktree: add -b/-B options

2015-07-05 Thread Eric Sunshine
On Fri, Jul 3, 2015 at 11:19 PM, Duy Nguyen pclo...@gmail.com wrote:
 On Sat, Jul 4, 2015 at 7:17 AM, Eric Sunshine sunsh...@sunshineco.com wrote:
 One of git-worktree's roles is to populate the new worktree, much like
 git-checkout, and thus, for convenience, ought to support several of the
 same shortcuts. Toward this goal, add -b/-B options to create a new
 branch and check it out in the new worktree.

 There are some other  ref manipulation options we can bring over like
 --orphan and --track. But you can totally leave them out and we can
 add them back when people actually need them.

Yes. I added --force, -b/-B, and --detach because they are used by the
tests; and I considered --orphan and --track to be good candidates, as
well, but decided to omit them for now since the series is already
overly long.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 16/23] worktree: add -b/-B options

2015-07-03 Thread Duy Nguyen
On Sat, Jul 4, 2015 at 7:17 AM, Eric Sunshine sunsh...@sunshineco.com wrote:
 One of git-worktree's roles is to populate the new worktree, much like
 git-checkout, and thus, for convenience, ought to support several of the
 same shortcuts. Toward this goal, add -b/-B options to create a new
 branch and check it out in the new worktree.

There are some other  ref manipulation options we can bring over like
--orphan and --track. But you can totally leave them out and we can
add them back when people actually need them.
-- 
Duy
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 16/23] worktree: add -b/-B options

2015-07-03 Thread Eric Sunshine
One of git-worktree's roles is to populate the new worktree, much like
git-checkout, and thus, for convenience, ought to support several of the
same shortcuts. Toward this goal, add -b/-B options to create a new
branch and check it out in the new worktree.

Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---

For brevity, I intentionally mentioned only -b in the synopsis, and
omitted -B.

 Documentation/git-worktree.txt | 13 ++---
 builtin/worktree.c | 11 +++
 2 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt
index 96e2142..f6c3747 100644
--- a/Documentation/git-worktree.txt
+++ b/Documentation/git-worktree.txt
@@ -9,7 +9,7 @@ git-worktree - Manage multiple worktrees
 SYNOPSIS
 
 [verse]
-'git worktree add' [-f] [--detach] path branch
+'git worktree add' [-f] [--detach] [-b new-branch] path branch
 'git worktree prune' [-n] [-v] [--expire expire]
 
 DESCRIPTION
@@ -65,6 +65,14 @@ OPTIONS
is already checked out by another worktree. This option overrides
that safeguard.
 
+-b new-branch::
+-B new-branch::
+   With `add`, create a new branch named `new-branch` starting at
+   `branch`, and check out `new-branch` into the new worktree.
+   By default, `-b` refuses to create a new branch if it already
+   exists. `-B` overrides this safeguard, resetting `new-branch` to
+   `branch`.
+
 --detach::
With `add`, detach HEAD in the new worktree. See DETACHED HEAD in
linkgit:git-checkout[1].
@@ -134,8 +142,7 @@ make the emergency fix, remove it when done, and then 
resume your earlier
 refactoring session.
 
 
-$ git branch emergency-fix master
-$ git worktree add ../temp emergency-fix
+$ git worktree add -b emergency-fix ../temp master
 $ pushd ../temp
 # ... hack hack hack ...
 $ git commit -a -m 'emergency fix for boss'
diff --git a/builtin/worktree.c b/builtin/worktree.c
index 6967369..d461d31 100644
--- a/builtin/worktree.c
+++ b/builtin/worktree.c
@@ -127,15 +127,22 @@ static int add(int ac, const char **av, const char 
*prefix)
 {
struct child_process c;
int force = 0, detach = 0;
+   const char *new_branch = NULL, *new_branch_force = NULL;
const char *path, *branch;
struct argv_array cmd = ARGV_ARRAY_INIT;
struct option options[] = {
OPT__FORCE(force, N_(checkout branch even if already 
checked out in other worktree)),
+   OPT_STRING('b', NULL, new_branch, N_(branch),
+  N_(create a new branch)),
+   OPT_STRING('B', NULL, new_branch_force, N_(branch),
+  N_(create or reset a branch)),
OPT_BOOL(0, detach, detach, N_(detach HEAD at named 
commit)),
OPT_END()
};
 
ac = parse_options(ac, av, prefix, options, worktree_usage, 0);
+   if (new_branch  new_branch_force)
+   die(_(-b and -B are mutually exclusive));
if (ac != 2)
usage_with_options(worktree_usage, options);
 
@@ -146,6 +153,10 @@ static int add(int ac, const char **av, const char *prefix)
argv_array_pushl(cmd, --to, path, NULL);
if (force)
argv_array_push(cmd, --ignore-other-worktrees);
+   if (new_branch)
+   argv_array_pushl(cmd, -b, new_branch, NULL);
+   if (new_branch_force)
+   argv_array_pushl(cmd, -B, new_branch_force, NULL);
if (detach)
argv_array_push(cmd, --detach);
argv_array_push(cmd, branch);
-- 
2.5.0.rc1.197.g417e668

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html