Re: [PATCH v2 2/2] completion: add support for completing email aliases

[Eric Sunshine]

On Sun, Nov 15, 2015 at 3:22 PM, Jacob Keller  wrote:
> Using the new --list-aliases option from git-send-email, add completion
> for --to, --cc, and --bcc with the available configured aliases.
>
> Signed-off-by: Jacob Keller 
> ---
> diff --git a/contrib/completion/git-completion.bash 
> b/contrib/completion/git-completion.bash
> @@ -1711,6 +1712,15 @@ __git_send_email_suppresscc_options="author self cc 
> bodycc sob cccmd body all"
>
>  _git_send_email ()
>  {
> +   case "$prev" in
> +   --to|--cc|--bcc)

What about --from, which also undergoes alias expansion?

> +   __gitcomp "
> +   $(git --git-dir="$(__gitdir)" send-email --list-aliases 
> 2>/dev/null)
> +   " "" ""
> +   return
> +   ;;
> +   esac
> +
> case "$cur" in
> --confirm=*)
> __gitcomp "
> @@ -1735,6 +1745,12 @@ _git_send_email ()
> " "" "${cur##--thread=}"
> return
> ;;
> +   --to=*|--cc=*|--bcc=*)
> +   __gitcomp "
> +   $(git --git-dir="$(__gitdir)" send-email --list-aliases 
> 2>/dev/null)
> +   " "" "${cur#--*=}"
> +   return
> +   ;;
> --*)
> __gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
> --compose --confirm= --dry-run --envelope-sender
> --
> 2.6.3.491.g3e3f6ce
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] completion: add support for completing email aliases

[Keller, Jacob E]

On Mon, 2015-11-16 at 18:33 -0500, Eric Sunshine wrote:
> On Sun, Nov 15, 2015 at 3:22 PM, Jacob Keller  om> wrote:
> > Using the new --list-aliases option from git-send-email, add
> > completion
> > for --to, --cc, and --bcc with the available configured aliases.
> > 
> > Signed-off-by: Jacob Keller 
> > ---
> > diff --git a/contrib/completion/git-completion.bash
> > b/contrib/completion/git-completion.bash
> > @@ -1711,6 +1712,15 @@ __git_send_email_suppresscc_options="author
> > self cc bodycc sob cccmd body all"
> > 
> >  _git_send_email ()
> >  {
> > +   case "$prev" in
> > +   --to|--cc|--bcc)
> 
> What about --from, which also undergoes alias expansion?
> 

Makes sense, yep.

N�r��yb�X��ǧv�^�)޺{.n�+ا���ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf

[PATCH v2 2/2] completion: add support for completing email aliases

[Jacob Keller]

From: Jacob Keller 

Using the new --list-aliases option from git-send-email, add completion
for --to, --cc, and --bcc with the available configured aliases.

Signed-off-by: Jacob Keller 
---

Notes:
- v2
* reuse parsing from git-send-email via --list-aliases

 contrib/completion/git-completion.bash | 16 
 1 file changed, 16 insertions(+)

diff --git a/contrib/completion/git-completion.bash 
b/contrib/completion/git-completion.bash
index 482ca84b451b..fde246e2943e 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -10,6 +10,7 @@
 #*) local and remote tag names
 #*) .git/remotes file names
 #*) git 'subcommands'
+#*) git email aliases for git-send-email
 #*) tree paths within 'ref:path/to/file' expressions
 #*) file paths within current working directory and index
 #*) common --long-options
@@ -1711,6 +1712,15 @@ __git_send_email_suppresscc_options="author self cc 
bodycc sob cccmd body all"
 
 _git_send_email ()
 {
+   case "$prev" in
+   --to|--cc|--bcc)
+   __gitcomp "
+   $(git --git-dir="$(__gitdir)" send-email --list-aliases 
2>/dev/null)
+   " "" ""
+   return
+   ;;
+   esac
+
case "$cur" in
--confirm=*)
__gitcomp "
@@ -1735,6 +1745,12 @@ _git_send_email ()
" "" "${cur##--thread=}"
return
;;
+   --to=*|--cc=*|--bcc=*)
+   __gitcomp "
+   $(git --git-dir="$(__gitdir)" send-email --list-aliases 
2>/dev/null)
+   " "" "${cur#--*=}"
+   return
+   ;;
--*)
__gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
--compose --confirm= --dry-run --envelope-sender
-- 
2.6.3.491.g3e3f6ce

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html