Re: [PATCH v2 2/9] t3701: indent here documents

[Eric Sunshine]

On Mon, Feb 19, 2018 at 6:29 AM, Phillip Wood  wrote:
> From: Phillip Wood 
>
> Indent here documents in line with the current style for tests.
>
> Signed-off-by: Phillip Wood 
> ---
> diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
> @@ -22,14 +22,14 @@ test_expect_success 'status works (initial)' '
>  test_expect_success 'setup expected' '
> -cat >expected < -new file mode 100644
> -index 000..d95f3ad
>  /dev/null
> -+++ b/file
> -@@ -0,0 +1 @@
> -+content
> -EOF
> +   cat >expected <<-EOF

Minor: You could take the opportunity to update these to use -\EOF
(rather than -EOF) to document that no variable interpolation is
expected inside the 'here' document. Probably itself not worth a
re-roll.

> +   new file mode 100644
> +   index 000..d95f3ad
> +   --- /dev/null
> +   +++ b/file
> +   @@ -0,0 +1 @@
> +   +content
> +   EOF
>  '

[PATCH v2 2/9] t3701: indent here documents

[Phillip Wood]

From: Phillip Wood 

Indent here documents in line with the current style for tests.

Signed-off-by: Phillip Wood 
---
 t/t3701-add-interactive.sh | 174 ++---
 1 file changed, 87 insertions(+), 87 deletions(-)

diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
index 
058698df6a4a9811b9db84fb5900472c47c61798..861ea2e08cce750515f59fc424b3f8336fd9b1a9
 100755
--- a/t/t3701-add-interactive.sh
+++ b/t/t3701-add-interactive.sh
@@ -22,14 +22,14 @@ test_expect_success 'status works (initial)' '
 '
 
 test_expect_success 'setup expected' '
-cat >expected expected expected patch fake_editor.sh &&
-   cat >>fake_editor.sh <<\EOF &&
-mv -f "$1" oldpatch &&
-mv -f patch "$1"
-EOF
+   cat >>fake_editor.sh <<-\EOF &&
+   mv -f "$1" oldpatch &&
+   mv -f patch "$1"
+   EOF
chmod a+x fake_editor.sh &&
test_set_editor "$(pwd)/fake_editor.sh"
 '
@@ -126,10 +126,10 @@ test_expect_success 'bad edit rejected' '
 '
 
 test_expect_success 'setup patch' '
-cat >patch patch expected patch expected expected expected