Re: [PATCH v2 3/4] real_path: create real_pathdup

[Johannes Sixt]

Am 09.12.2016 um 00:58 schrieb Brandon Williams:

+char *real_pathdup(const char *path)
+{
+   struct strbuf realpath = STRBUF_INIT;
+   char *retval = NULL;
+
+   if(strbuf_realpath(, path, 0))


Style nit: blank after if is missing.

-- Hannes

[PATCH v2 3/4] real_path: create real_pathdup

[Brandon Williams]

Create real_pathdup which returns a caller owned string of the resolved
realpath based on the provide path.

Signed-off-by: Brandon Williams 
---
 abspath.c | 13 +
 cache.h   |  1 +
 2 files changed, 14 insertions(+)

diff --git a/abspath.c b/abspath.c
index b0d4c1b..df37356 100644
--- a/abspath.c
+++ b/abspath.c
@@ -198,6 +198,19 @@ const char *real_path_if_valid(const char *path)
return strbuf_realpath(, path, 0);
 }
 
+char *real_pathdup(const char *path)
+{
+   struct strbuf realpath = STRBUF_INIT;
+   char *retval = NULL;
+
+   if(strbuf_realpath(, path, 0))
+   retval = strbuf_detach(, NULL);
+
+   strbuf_release();
+
+   return retval;
+}
+
 /*
  * Use this to get an absolute path from a relative one. If you want
  * to resolve links, you should use real_path.
diff --git a/cache.h b/cache.h
index 7a81294..e12a5d9 100644
--- a/cache.h
+++ b/cache.h
@@ -1068,6 +1068,7 @@ char *strbuf_realpath(struct strbuf *resolved, const char 
*path,
  int die_on_error);
 const char *real_path(const char *path);
 const char *real_path_if_valid(const char *path);
+char *real_pathdup(const char *path);
 const char *absolute_path(const char *path);
 const char *remove_leading_path(const char *in, const char *prefix);
 const char *relative_path(const char *in, const char *prefix, struct strbuf 
*sb);
-- 
2.8.0.rc3.226.g39d4020