RE: [PATCH v3 09/10] remote-hg: test: be a little more quiet
No-brainer; improve one test. Felipe Contreras wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- contrib/remote-helpers/test-hg.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 8de2aa7..f8d1f9e 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -109,10 +109,10 @@ test_expect_success 'update bookmark' ' ( git clone hg::$PWD/hgrepo gitrepo cd gitrepo - git checkout devel + git checkout --quiet devel echo devel content git commit -a -m devel - git push + git push --quiet ) hg -R hgrepo bookmarks | egrep devel[ ]+3: -- 1.8.3.rc1.579.g184e698 -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 09/10] remote-hg: test: be a little more quiet
Felipe Contreras felipe.contre...@gmail.com writes: No-brainer; improve one test. In general, unless we are taking the output from commands to a file and grepping in it, we prefer not to have --quiet (unless you are testing the --quiet feature of the command, of course). Running the tests without -v option will not show them and when running with -v to debug the tests, the extra output will help to figure out which step failed. Felipe Contreras wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- contrib/remote-helpers/test-hg.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 8de2aa7..f8d1f9e 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -109,10 +109,10 @@ test_expect_success 'update bookmark' ' ( git clone hg::$PWD/hgrepo gitrepo cd gitrepo - git checkout devel + git checkout --quiet devel echo devel content git commit -a -m devel - git push + git push --quiet ) hg -R hgrepo bookmarks | egrep devel[ ]+3: -- 1.8.3.rc1.579.g184e698 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 09/10] remote-hg: test: be a little more quiet
On Tue, May 14, 2013 at 4:40 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: No-brainer; improve one test. In general, unless we are taking the output from commands to a file and grepping in it, we prefer not to have --quiet (unless you are testing the --quiet feature of the command, of course). Running the tests without -v option will not show them and when running with -v to debug the tests, the extra output will help to figure out which step failed. Yeah, but I spent a long time looking at the output of these tests and grew tired of all the irrelevant noise. In fact, I'm even tempted to set push.default because of that annoying message all over them. Maybe the --quiet for the push shouldn't be there, but the --quiet for checkout definitely. Either way, I don't see much value in changing this patch at this point. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 09/10] remote-hg: test: be a little more quiet
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- contrib/remote-helpers/test-hg.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 8de2aa7..f8d1f9e 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -109,10 +109,10 @@ test_expect_success 'update bookmark' ' ( git clone hg::$PWD/hgrepo gitrepo cd gitrepo - git checkout devel + git checkout --quiet devel echo devel content git commit -a -m devel - git push + git push --quiet ) hg -R hgrepo bookmarks | egrep devel[]+3: -- 1.8.3.rc1.579.g184e698 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
