[PATCH v3 2/7] completion: get rid of empty COMPREPLY assignments

2013-04-10 Thread Felipe Contreras
There's no functional reason for those, the only purpose they are
supposed to serve is to say we don't provide any words here, but even
for that it's not used consitently.

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
 contrib/completion/git-completion.bash | 21 -
 1 file changed, 21 deletions(-)

diff --git a/contrib/completion/git-completion.bash 
b/contrib/completion/git-completion.bash
index 93eba46..2c87fd8 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -208,7 +208,6 @@ __gitcomp ()
 
case $cur_ in
--*=)
-   COMPREPLY=()
;;
*)
local IFS=$'\n'
@@ -614,7 +613,6 @@ __git_complete_remote_or_refspec ()
case $cmd in
push) no_complete_refspec=1 ;;
fetch)
-   COMPREPLY=()
return
;;
*) ;;
@@ -630,7 +628,6 @@ __git_complete_remote_or_refspec ()
return
fi
if [ $no_complete_refspec = 1 ]; then
-   COMPREPLY=()
return
fi
[ $remote = . ]  remote=
@@ -951,7 +948,6 @@ _git_am ()

return
esac
-   COMPREPLY=()
 }
 
 _git_apply ()
@@ -971,7 +967,6 @@ _git_apply ()

return
esac
-   COMPREPLY=()
 }
 
 _git_add ()
@@ -1031,7 +1026,6 @@ _git_bisect ()
__gitcomp_nl $(__git_refs)
;;
*)
-   COMPREPLY=()
;;
esac
 }
@@ -1170,7 +1164,6 @@ _git_clone ()
return
;;
esac
-   COMPREPLY=()
 }
 
 _git_commit ()
@@ -1354,7 +1347,6 @@ _git_fsck ()
return
;;
esac
-   COMPREPLY=()
 }
 
 _git_gc ()
@@ -1365,7 +1357,6 @@ _git_gc ()
return
;;
esac
-   COMPREPLY=()
 }
 
 _git_gitk ()
@@ -1442,7 +1433,6 @@ _git_init ()
return
;;
esac
-   COMPREPLY=()
 }
 
 _git_ls_files ()
@@ -1578,7 +1568,6 @@ _git_mergetool ()
return
;;
esac
-   COMPREPLY=()
 }
 
 _git_merge_base ()
@@ -1891,7 +1880,6 @@ _git_config ()
return
;;
*.*)
-   COMPREPLY=()
return
;;
esac
@@ -2272,7 +2260,6 @@ _git_remote ()
__gitcomp $c
;;
*)
-   COMPREPLY=()
;;
esac
 }
@@ -2388,8 +2375,6 @@ _git_stash ()
*)
if [ -z $(__git_find_on_cmdline $save_opts) ]; then
__gitcomp $subcommands
-   else
-   COMPREPLY=()
fi
;;
esac
@@ -2402,14 +2387,12 @@ _git_stash ()
__gitcomp --index --quiet
;;
show,--*|drop,--*|branch,--*)
-   COMPREPLY=()
;;
show,*|apply,*|drop,*|pop,*|branch,*)
__gitcomp_nl $(git --git-dir=$(__gitdir) stash list \
| sed -n -e 's/:.*//p')
;;
*)
-   COMPREPLY=()
;;
esac
fi
@@ -2526,7 +2509,6 @@ _git_svn ()
__gitcomp --revision= --parent
;;
*)
-   COMPREPLY=()
;;
esac
fi
@@ -2551,13 +2533,10 @@ _git_tag ()
 
case $prev in
-m|-F)
-   COMPREPLY=()
;;
-*|tag)
if [ $f = 1 ]; then
__gitcomp_nl $(__git_tags)
-   else
-   COMPREPLY=()
fi
;;
*)
-- 
1.8.2.1

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v3 2/7] completion: get rid of empty COMPREPLY assignments

2013-04-10 Thread Eric Sunshine
On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras
felipe.contre...@gmail.com wrote:
 There's no functional reason for those, the only purpose they are
 supposed to serve is to say we don't provide any words here, but even
 for that it's not used consitently.

s/consitently/consistently/

 Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html