Re: [PATCH v4 03/32] rollback_lock_file(): do not clear filename redundantly

2014-09-11 Thread Ronnie Sahlberg
Reviewed-by: Ronnie Sahlberg sahlb...@google.com

On Sat, Sep 6, 2014 at 12:50 AM, Michael Haggerty mhag...@alum.mit.edu wrote:
 It is only necessary to clear the lock_file's filename field if it was
 not already clear.

 Signed-off-by: Michael Haggerty mhag...@alum.mit.edu
 ---
  lockfile.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/lockfile.c b/lockfile.c
 index f1ce154..a548e08 100644
 --- a/lockfile.c
 +++ b/lockfile.c
 @@ -276,6 +276,6 @@ void rollback_lock_file(struct lock_file *lk)
 if (lk-fd = 0)
 close(lk-fd);
 unlink_or_warn(lk-filename);
 +   lk-filename[0] = 0;
 }
 -   lk-filename[0] = 0;
  }
 --
 2.1.0

 --
 To unsubscribe from this list: send the line unsubscribe git in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v4 03/32] rollback_lock_file(): do not clear filename redundantly

2014-09-06 Thread Michael Haggerty
It is only necessary to clear the lock_file's filename field if it was
not already clear.

Signed-off-by: Michael Haggerty mhag...@alum.mit.edu
---
 lockfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lockfile.c b/lockfile.c
index f1ce154..a548e08 100644
--- a/lockfile.c
+++ b/lockfile.c
@@ -276,6 +276,6 @@ void rollback_lock_file(struct lock_file *lk)
if (lk-fd = 0)
close(lk-fd);
unlink_or_warn(lk-filename);
+   lk-filename[0] = 0;
}
-   lk-filename[0] = 0;
 }
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html