Re: [PATCH v5 00/10] Partial clone part 2: fsck and promisors
On Wed, Nov 22, 2017 at 10:00 AM, Jonathan Tan wrote: > On Wed, 22 Nov 2017 14:25:13 +0900 > Junio C Hamano wrote: > >> Thanks, will replace/queue all three series. I am getting a feeling >> that the first one is already ready for 'next', while the other two >> may want to see a bit more comments? > > Yes, I think so too. > > Jeff Hostetler and I noticed some issues occuring when some other Git > commands dynamically fetch objects due to the fact that those commands > and fetch-pack use overlapping object flags. At the very least, we > should look at that before it goes into next. In the end, making fetch-pack refrain from setting object flags when being used to dynamically fetch objects works (see the new "introduce fetch-object: fetch one promisor object" commit that I just pushed to [1]). I'll coordinate with Jeff Hostetler about sending v6 to the list (most likely after the U.S. Thanksgiving holidays). [1] https://github.com/jonathantanmy/git/commits/pc20171122
Re: [PATCH v5 00/10] Partial clone part 2: fsck and promisors
On Wed, 22 Nov 2017 14:25:13 +0900 Junio C Hamano wrote: > Jeff Hostetler writes: > > > From: Jeff Hostetler > > > > This is V5 of part 2 of partial clone. This assumes V5 of part 1 > > is already present. V5 includes minor cleanup over V4 and better > > separates the --exclude-promisor-objects and --missing arguments. > > > > Part 2 is concerned with fsck, gc, initial support for dynamic > > object fetching, and tracking promisor objects. Jonathan Tan > > originally developed this code. I have moved it on top of > > part 1 and updated it slightly. > > Thanks, will replace/queue all three series. I am getting a feeling > that the first one is already ready for 'next', while the other two > may want to see a bit more comments? Yes, I think so too. Jeff Hostetler and I noticed some issues occuring when some other Git commands dynamically fetch objects due to the fact that those commands and fetch-pack use overlapping object flags. At the very least, we should look at that before it goes into next.
Re: [PATCH v5 00/10] Partial clone part 2: fsck and promisors
Jeff Hostetler writes: > From: Jeff Hostetler > > This is V5 of part 2 of partial clone. This assumes V5 of part 1 > is already present. V5 includes minor cleanup over V4 and better > separates the --exclude-promisor-objects and --missing arguments. > > Part 2 is concerned with fsck, gc, initial support for dynamic > object fetching, and tracking promisor objects. Jonathan Tan > originally developed this code. I have moved it on top of > part 1 and updated it slightly. Thanks, will replace/queue all three series. I am getting a feeling that the first one is already ready for 'next', while the other two may want to see a bit more comments?
[PATCH v5 00/10] Partial clone part 2: fsck and promisors
From: Jeff Hostetler This is V5 of part 2 of partial clone. This assumes V5 of part 1 is already present. V5 includes minor cleanup over V4 and better separates the --exclude-promisor-objects and --missing arguments. Part 2 is concerned with fsck, gc, initial support for dynamic object fetching, and tracking promisor objects. Jonathan Tan originally developed this code. I have moved it on top of part 1 and updated it slightly. Jonathan Tan (10): extension.partialclone: introduce partial clone extension fsck: introduce partialclone extension fsck: support refs pointing to promisor objects fsck: support referenced promisor objects fsck: support promisor objects as CLI argument index-pack: refactor writing of .keep files introduce fetch-object: fetch one promisor object sha1_file: support lazily fetching missing objects rev-list: support termination at promisor objects gc: do not repack promisor packfiles Documentation/git-pack-objects.txt | 11 + Documentation/gitremote-helpers.txt| 6 + Documentation/rev-list-options.txt | 11 + Documentation/technical/repository-version.txt | 12 + Makefile | 1 + builtin/cat-file.c | 2 + builtin/fetch-pack.c | 10 + builtin/fsck.c | 26 +- builtin/gc.c | 3 + builtin/index-pack.c | 113 builtin/pack-objects.c | 37 ++- builtin/prune.c| 7 + builtin/repack.c | 8 +- builtin/rev-list.c | 71 - cache.h| 13 +- environment.c | 1 + fetch-object.c | 27 ++ fetch-object.h | 6 + fetch-pack.c | 8 +- fetch-pack.h | 2 + list-objects.c | 29 ++- object.c | 2 +- packfile.c | 77 +- packfile.h | 13 + remote-curl.c | 14 +- revision.c | 33 ++- revision.h | 5 +- setup.c| 7 +- sha1_file.c| 38 ++- t/t0410-partial-clone.sh | 343 + transport.c| 8 + transport.h| 8 + 32 files changed, 869 insertions(+), 83 deletions(-) create mode 100644 fetch-object.c create mode 100644 fetch-object.h create mode 100755 t/t0410-partial-clone.sh -- 2.9.3
