Re: [PATCH v6 0/4] config: add '--sources' option to print the source of a config value
larsxschnei...@gmail.com writes: > From: Lars Schneider > > diff to v5: > * rename 'type' to 'origin_type' as 'type' is too broad a word in the context > of configuration file (Thanks to the reviewers Junio and Dscho) > * add dedicated patch to rename git_config_from_buf to git_config_from_mem > (this change was part of the series since v4 as suggested by Junio but > hidden in the "config: add 'origin_type'" patch) > > Thanks, > Lars Overall this round looks good. I personally prefer 'stdin' to be spelled out as '(the) standard input' in end-user facing messages, e.g. the expected message in this piece test_expect_success 'invalid stdin config' ' echo "fatal: bad config line 1 in stdin " >expect && to say "line 1 in the standard input", but that is a quite minor point and just a preference. Thanks. Let's queue this version and move it forward to 'next' soonish. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 0/4] config: add '--sources' option to print the source of a config value
From: Lars Schneider diff to v5: * rename 'type' to 'origin_type' as 'type' is too broad a word in the context of configuration file (Thanks to the reviewers Junio and Dscho) * add dedicated patch to rename git_config_from_buf to git_config_from_mem (this change was part of the series since v4 as suggested by Junio but hidden in the "config: add 'origin_type'" patch) Thanks, Lars Lars Schneider (4): t: do not hide Git's exit code in tests using 'nul_to_q' rename git_config_from_buf to git_config_from_mem config: add 'origin_type' to config_source struct config: add '--show-origin' option to print the origin of a config value Documentation/git-config.txt | 15 ++-- builtin/config.c | 33 + cache.h | 6 +- config.c | 36 +++--- submodule-config.c | 4 +- t/t1300-repo-config.sh | 161 ++- t/t1308-config-set.sh| 4 +- t/t7008-grep-binary.sh | 3 +- 8 files changed, 236 insertions(+), 26 deletions(-) -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
