Re: [PATCH v6 07/13] pack-protocol: fix maximum pkt-line size
Lars Schneiderwrites: >> And as this is a strict bug fix of Documentation that makes sense >> outside this series, > > Agreed! Amen. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 07/13] pack-protocol: fix maximum pkt-line size
> On 25 Aug 2016, at 20:59, Stefan Bellerwrote: > >> On Thu, Aug 25, 2016 at 4:07 AM, wrote: >> From: Lars Schneider >> >> According to LARGE_PACKET_MAX in pkt-line.h the maximal length of a >> pkt-line packet is 65520 bytes. The pkt-line header takes 4 bytes and >> therefore the pkt-line data component must not exceed 65516 bytes. >> >> Signed-off-by: Lars Schneider >> --- > > I was recently encouraged off list to really try hard to go with > shorter series's. > (Duh! Everyone knows that shorter series go in faster ;) > > And as this is a strict bug fix of Documentation that makes sense > outside this series, > I'd like to encourage you to send this as a separate patch in case you > need further > rerolls. Agreed! Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 07/13] pack-protocol: fix maximum pkt-line size
On Thu, Aug 25, 2016 at 4:07 AM,wrote: > From: Lars Schneider > > According to LARGE_PACKET_MAX in pkt-line.h the maximal length of a > pkt-line packet is 65520 bytes. The pkt-line header takes 4 bytes and > therefore the pkt-line data component must not exceed 65516 bytes. > > Signed-off-by: Lars Schneider > --- I was recently encouraged off list to really try hard to go with shorter series's. (Duh! Everyone knows that shorter series go in faster ;) And as this is a strict bug fix of Documentation that makes sense outside this series, I'd like to encourage you to send this as a separate patch in case you need further rerolls. Thanks, Stefan > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 07/13] pack-protocol: fix maximum pkt-line size
From: Lars SchneiderAccording to LARGE_PACKET_MAX in pkt-line.h the maximal length of a pkt-line packet is 65520 bytes. The pkt-line header takes 4 bytes and therefore the pkt-line data component must not exceed 65516 bytes. Signed-off-by: Lars Schneider --- Documentation/technical/protocol-common.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/technical/protocol-common.txt b/Documentation/technical/protocol-common.txt index bf30167..ecedb34 100644 --- a/Documentation/technical/protocol-common.txt +++ b/Documentation/technical/protocol-common.txt @@ -67,9 +67,9 @@ with non-binary data the same whether or not they contain the trailing LF (stripping the LF if present, and not complaining when it is missing). -The maximum length of a pkt-line's data component is 65520 bytes. -Implementations MUST NOT send pkt-line whose length exceeds 65524 -(65520 bytes of payload + 4 bytes of length data). +The maximum length of a pkt-line's data component is 65516 bytes. +Implementations MUST NOT send pkt-line whose length exceeds 65520 +(65516 bytes of payload + 4 bytes of length data). Implementations SHOULD NOT send an empty pkt-line ("0004"). -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html