Re: [PATCHv2 3/5] submodule--helper clone: remove double path checking

[Junio C Hamano]

Eric Sunshine  writes:

> On Thu, Mar 31, 2016 at 5:04 PM, Stefan Beller  wrote:
>> submodule--helper clone: remove double path checking
>
> I think Junio mentioned in v1 that calling this "path checking" is misleading.

I'd tentatively use:

"submodule--helper clone: create the submodule path just once"

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 3/5] submodule--helper clone: remove double path checking

[Eric Sunshine]

On Thu, Mar 31, 2016 at 5:04 PM, Stefan Beller  wrote:
> submodule--helper clone: remove double path checking

I think Junio mentioned in v1 that calling this "path checking" is misleading.

> We make sure that the parent directory of path exists (or create it
> otherwise) and then do the same for path + "/.git".
>
> That is equivalent to just making sure that the parent directory of
> path + "/.git" exists (or create it otherwise).

This part of the commit message is nicely improved.

The patch itself looks fine.

> Signed-off-by: Stefan Beller 
> ---
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> @@ -215,11 +215,7 @@ static int module_clone(int argc, const char **argv, 
> const char *prefix)
> }
>
> /* Write a .git file in the submodule to redirect to the 
> superproject. */
> -   if (safe_create_leading_directories_const(path) < 0)
> -   die(_("could not create directory '%s'"), path);
> -
> strbuf_addf(, "%s/.git", path);
> -
> if (safe_create_leading_directories_const(sb.buf) < 0)
> die(_("could not create leading directories of '%s'"), 
> sb.buf);
> submodule_dot_git = fopen(sb.buf, "w");
> --
> 2.5.0.264.g39f00fe
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv2 3/5] submodule--helper clone: remove double path checking

[Stefan Beller]

We make sure that the parent directory of path exists (or create it
otherwise) and then do the same for path + "/.git".

That is equivalent to just making sure that the parent directory of
path + "/.git" exists (or create it otherwise).

Signed-off-by: Stefan Beller 
---
 builtin/submodule--helper.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 4f0b002..0b9f546 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -215,11 +215,7 @@ static int module_clone(int argc, const char **argv, const 
char *prefix)
}
 
/* Write a .git file in the submodule to redirect to the superproject. 
*/
-   if (safe_create_leading_directories_const(path) < 0)
-   die(_("could not create directory '%s'"), path);
-
strbuf_addf(, "%s/.git", path);
-
if (safe_create_leading_directories_const(sb.buf) < 0)
die(_("could not create leading directories of '%s'"), sb.buf);
submodule_dot_git = fopen(sb.buf, "w");
-- 
2.5.0.264.g39f00fe

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html