Re: [RFC/PATCH 0/4] Remove deprecated commands
On Mon, Nov 11, 2013 at 11:13:45AM -0800, Jonathan Nieder wrote: > John Keeping wrote: > > On Mon, Nov 11, 2013 at 10:25:51AM -0800, Junio C Hamano wrote: > >> John Keeping writes: > > >>> "git repo-config", "git tar-tree", "git lost-found" and "git > >>> peek-remote" have all been deprecated since at least Git 1.5.4. > [...] > >> Probably good material to discuss during the next cycle. > [...] > > I was assuming these would be queued as a "held until 2.0" branch, but > > Please no. :) We already have a nice set of features for 2.0 and I > hope people have as few excuses not to upgrade as possible. Anything > that actually needs the same kind of treatment that is introduced now > should wait for 3.0. > > Removing repo-config, tar-tree, and peek-remote sounds fine to me > (though I haven't thought much about it either way) and I agree that > it wouldn't need to wait for an x.0 release. For "git repo-config", the 1.5.4 release notes say that it will "be removed in the next feature release". I'm not sure what a "feature release" is, but if 1.6.0 wasn't one, then I think 2.0 will be the next one. Although, I now see that howto/maintain-git.txt says a feature release is numbered vX.Y.Z, so perhaps it should have been removed long before now... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH 0/4] Remove deprecated commands
John Keeping wrote: > On Mon, Nov 11, 2013 at 10:25:51AM -0800, Junio C Hamano wrote: >> John Keeping writes: >>> "git repo-config", "git tar-tree", "git lost-found" and "git >>> peek-remote" have all been deprecated since at least Git 1.5.4. [...] >> Probably good material to discuss during the next cycle. [...] > I was assuming these would be queued as a "held until 2.0" branch, but Please no. :) We already have a nice set of features for 2.0 and I hope people have as few excuses not to upgrade as possible. Anything that actually needs the same kind of treatment that is introduced now should wait for 3.0. Removing repo-config, tar-tree, and peek-remote sounds fine to me (though I haven't thought much about it either way) and I agree that it wouldn't need to wait for an x.0 release. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH 0/4] Remove deprecated commands
On Mon, Nov 11, 2013 at 10:25:51AM -0800, Junio C Hamano wrote: > John Keeping writes: > > > "git repo-config", "git tar-tree", "git lost-found" and "git > > peek-remote" have all been deprecated since at least Git 1.5.4. > > > > With Git 2.0 approaching, I think that would be a good point to remove > > then completely, which is what this series does. > > Probably good material to discuss during the next cycle. > > As a totally unscientific sanity check, I asked Google to show these > since Nov 13, 2011: > > [git repo-config] vs [git config]: 136 vs 232 > > [git peek-remote] vs [git ls-remote]: 62 vs 133 > > [git tar-tree] vs [git archive]: 73 vs 189 > > [git lost-found] vs [git fsck --lost-found]: 96 vs 83 > > So I think 1, 2, and 4 are OK to ship in whatever version that comes > after the upcoming 1.8.5, but we might have to hold onto lost-found > a bit longer. The command does show a deprecation warning, so there > is nothing to change at this point. I was assuming these would be queued as a "held until 2.0" branch, but if you think some can go earlier I can re-send this once 1.8.5 is out of the way. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH 0/4] Remove deprecated commands
John Keeping writes: > "git repo-config", "git tar-tree", "git lost-found" and "git > peek-remote" have all been deprecated since at least Git 1.5.4. > > With Git 2.0 approaching, I think that would be a good point to remove > then completely, which is what this series does. Probably good material to discuss during the next cycle. As a totally unscientific sanity check, I asked Google to show these since Nov 13, 2011: [git repo-config] vs [git config]: 136 vs 232 [git peek-remote] vs [git ls-remote]: 62 vs 133 [git tar-tree] vs [git archive]: 73 vs 189 [git lost-found] vs [git fsck --lost-found]: 96 vs 83 So I think 1, 2, and 4 are OK to ship in whatever version that comes after the upcoming 1.8.5, but we might have to hold onto lost-found a bit longer. The command does show a deprecation warning, so there is nothing to change at this point. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC/PATCH 0/4] Remove deprecated commands
"git repo-config", "git tar-tree", "git lost-found" and "git peek-remote" have all been deprecated since at least Git 1.5.4. With Git 2.0 approaching, I think that would be a good point to remove then completely, which is what this series does. John Keeping (4): repo-config: remove deprecated alias for "git config" tar-tree: remove deprecated command lost-found: remove deprecated command peek-remote: remove deprecated alias of ls-remote .gitignore | 4 -- Documentation/git-lost-found.txt | 74 -- Documentation/git-peek-remote.txt | 43 -- Documentation/git-repo-config.txt | 23 -- Documentation/git-tar-tree.txt | 82 -- Makefile | 3 -- builtin.h | 1 - builtin/config.c | 6 --- builtin/tar-tree.c | 62 - command-list.txt | 4 -- contrib/completion/git-completion.bash | 4 -- contrib/examples/git-whatchanged.sh| 4 +- git-lost-found.sh | 33 -- git.c | 3 -- t/t4116-apply-reverse.sh | 4 +- t/t5000-tar-tree.sh| 16 ++- t/t5001-archive-attr.sh| 10 - 17 files changed, 7 insertions(+), 369 deletions(-) delete mode 100644 Documentation/git-lost-found.txt delete mode 100644 Documentation/git-peek-remote.txt delete mode 100644 Documentation/git-repo-config.txt delete mode 100644 Documentation/git-tar-tree.txt delete mode 100755 git-lost-found.sh -- 1.8.5.rc0.170.g772b8ec -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
