Re: [cosmetic bug?] needlessly(?) executable files

2015-02-23 Thread Junio C Hamano 
Dennis Kaarsemaker  writes:

> On zo, 2015-02-22 at 10:44 -0800, Junio C Hamano wrote:
>> Christoph Anton Mitterer  writes:
>> 
>> > Just a question about files like:
>> > .git/config
>> > .git/hooks/*.sample
>> >
>> > Is there any reason that these are created executable? Especially
>> the
>> > config file?
>> 
>> In a new repository I just did "git init", I see this:
>> 
>> $ rm -fr stupid
>> $ umask 0027
>> $ git init stupid
>> $ ls -l stupid/.git/config | sed -e 's/ .*//'
>> -rw-r-
>> 
>> So no, config is not created executable.
>
> It used to be for a brief period in history, between daa22c6f8d (2.1.0)
> and 1f32ecf (2.2.2).

Ahh, yes, I think we fixed that bug not too long ago.

Thanks for reminding me.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [cosmetic bug?] needlessly(?) executable files

2015-02-23 Thread Christoph Anton Mitterer 
On Mon, 2015-02-23 at 09:21 +0100, Dennis Kaarsemaker wrote: 
> It used to be for a brief period in history, between daa22c6f8d (2.1.0)
> and 1f32ecf (2.2.2).
Ah thanks,... I have 2.1.4 which explains this :)


Cheers,
Chris.


smime.p7s
Description: S/MIME cryptographic signature

Re: [cosmetic bug?] needlessly(?) executable files

2015-02-23 Thread Dennis Kaarsemaker 
On zo, 2015-02-22 at 10:44 -0800, Junio C Hamano wrote:
> Christoph Anton Mitterer  writes:
> 
> > Just a question about files like:
> > .git/config
> > .git/hooks/*.sample
> >
> > Is there any reason that these are created executable? Especially
> the
> > config file?
> 
> In a new repository I just did "git init", I see this:
> 
> $ rm -fr stupid
> $ umask 0027
> $ git init stupid
> $ ls -l stupid/.git/config | sed -e 's/ .*//'
> -rw-r-
> 
> So no, config is not created executable.

It used to be for a brief period in history, between daa22c6f8d (2.1.0)
and 1f32ecf (2.2.2).

-- 
Dennis Kaarsemaker
http://www.kaarsemaker.net

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [cosmetic bug?] needlessly(?) executable files

2015-02-22 Thread Junio C Hamano 
Christoph Anton Mitterer  writes:

> Just a question about files like:
> .git/config
> .git/hooks/*.sample
>
> Is there any reason that these are created executable? Especially the
> config file?

In a new repository I just did "git init", I see this:

$ rm -fr stupid
$ umask 0027
$ git init stupid
$ ls -l stupid/.git/config | sed -e 's/ .*//'
-rw-r-

So no, config is not created executable.

> I know the hooks are already disabled by being named .sample,

I think that is deliberate, so that lazy people can just do:

$ mv .git/hooks/pre-commit.sample .git/hooks/pre-commit

without one more command

$ chmod +x .git/hooks/pre-commit

after doing so.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[cosmetic bug?] needlessly(?) executable files

2015-02-21 Thread Christoph Anton Mitterer 
Hey.

Just a question about files like:
.git/config
.git/hooks/*.sample

Is there any reason that these are created executable? Especially the
config file?
I know the hooks are already disabled by being named .sample, but having
them executable just increases the chance that one accidentally fires
them up manually.


Cheers,
Chris.


smime.p7s
Description: S/MIME cryptographic signature