Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column

2018-05-26 Thread Jeff Felchner
Todd, it looks like that may very well be the same issue.  And it looks like 
it's planning on being fixed in the next release?  Would that be 2.17.1 since 
it's a regression?

> On 2018 May 26, at 16:07, Todd Zullinger  wrote:
> 
> Hi Jeff,
> 
> Jeff Felchner wrote:
>> Ever since 2.17.0, when saving a patch (using add --patch
>> but probably other ways as well), if the whitespace is
>> removed from the initial column, the patch doesn't apply.
> 
> This sounds a bit like the issue discussed in this thread a
> few weeks ago:
> 
> https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9ad...@talktalk.net/
> 
> But I didn't download or watch the video, so I'm not positive.
> 
>> Full walkthrough (including comparison with 2.16.3) in the
>> video attached to this link:
>> 
>> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1
> 
> -- 
> Todd
> ~~
> Everybody knows how to raise children, except the people who have
> them.
>-- P.J. O'Rourke
> 



Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column

2018-05-26 Thread Todd Zullinger
Hi Jeff,

Jeff Felchner wrote:
> Ever since 2.17.0, when saving a patch (using add --patch
> but probably other ways as well), if the whitespace is
> removed from the initial column, the patch doesn't apply.

This sounds a bit like the issue discussed in this thread a
few weeks ago:

https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9ad...@talktalk.net/

But I didn't download or watch the video, so I'm not positive.

> Full walkthrough (including comparison with 2.16.3) in the
> video attached to this link:
> 
> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1

-- 
Todd
~~
Everybody knows how to raise children, except the people who have
them.
-- P.J. O'Rourke



2.17.0 Regression When Adding Patches Without Whitespace In Initial Column

2018-05-26 Thread Jeff Felchner
Ever since 2.17.0, when saving a patch (using add --patch but probably other 
ways as well), if the whitespace is removed from the initial column, the patch 
doesn't apply.

Full walkthrough (including comparison with 2.16.3) in the video attached to 
this link:

https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1