Bug in shallow clone?

2014-05-28 Thread Thomas Kieffer

Hi there Git developers,

I'm not sure if I found a bug in the command

git clone repo.git cloned_repo --depth 1

I follow these steps:

git init
echo First commit  test.txt
git add -A
git commit -am First commit

echo Second commit  test.txt
git commit -am Second commit

echo Third commit  test.txt
git commit -am Third commit

git clone --bare . ./bare.git

I then clone the bare repository with --depth 1.

git clone file:///path/to/bare.git ./clone --depth 1

It always returns the last two commits. If I specify --depth 2 it 
returns the last 3 commits.


If I use --depth 1 on a Github repository it works as expected.

Am I doing something wrong or is it really a bug?

Kind Regards,

Thomas Kieffer


BTW.: Git is amazing and I love it :)
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Bug in shallow clone?

2014-05-28 Thread Duy Nguyen
On Wed, May 28, 2014 at 9:02 PM, Thomas Kieffer thomaskief...@web.de wrote:
 I then clone the bare repository with --depth 1.

 git clone file:///path/to/bare.git ./clone --depth 1

 It always returns the last two commits. If I specify --depth 2 it returns
 the last 3 commits.

 If I use --depth 1 on a Github repository it works as expected.

 Am I doing something wrong or is it really a bug?

Depth calculation has been corrected lately. It depends on your
version, maybe it's older than 1.8.2? If it's the latest, we screwed
something up again..
-- 
Duy
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Bug in shallow clone?

2014-05-28 Thread Dennis Kaarsemaker
On wo, 2014-05-28 at 21:16 +0700, Duy Nguyen wrote:
 On Wed, May 28, 2014 at 9:02 PM, Thomas Kieffer thomaskief...@web.de wrote:
  I then clone the bare repository with --depth 1.
 
  git clone file:///path/to/bare.git ./clone --depth 1
 
  It always returns the last two commits. If I specify --depth 2 it returns
  the last 3 commits.
 
  If I use --depth 1 on a Github repository it works as expected.
 
  Am I doing something wrong or is it really a bug?
 
 Depth calculation has been corrected lately. It depends on your
 version, maybe it's older than 1.8.2? If it's the latest, we screwed
 something up again..

2.0.0-rc4 does this correctly.
-- 
Dennis Kaarsemaker
http://www.kaarsemaker.net

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html