Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage
Akshay Aurora akshayaurora2...@gmail.com writes: Thanks Junio. Working on v2 for this patch. On Sat, Mar 7, 2015 at 12:00 AM, Junio C Hamano gits...@pobox.com wrote: Please, don't top-post on this list. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage
Thanks for replying. I'll try sending the patch directly using gmail smtp servers next time. Going by the description of the options. I doubt --graph and --no-walk would ever make sense together. So my patch forbids these two options together for all commands calling setup_revisions(). And isn't specific to just `git log`. Also, seeing other patches to this microproject. I think I should also update Documentation for rev-list-options. Do you think we need a test for this? Would a test using only `git log` be suffice? On Fri, Mar 6, 2015 at 2:07 PM, Max Kirillov m...@max630.net wrote: On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora akshayaur...@yahoo.com wrote: Not sure, why this mail is not showing on Gmane. I used git to send the email, and tested it by sending the patch to myself before sending it to the list. Gmail knows: Why is this message in Spam? It has a from address in yahoo.com but has failed yahoo.com's required tests for authentication. Learn more Probably filtering settings are less strict. I guess you should use authenticated SMTP thought your email hoster, yahoo here in git-send-email (something like --smtp-server and --smtp-user options, it will ask for password interactively) to avoid it. -- AA -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage
Akshay Aurora akshayaur...@yahoo.com writes: Signed-off-by: Akshay Aurora akshayaur...@yahoo.com --- This is my first patch for a GSoC Microproject, would be great to have your feedback. revision.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/revision.c b/revision.c index bd027bc..d578652 100644 --- a/revision.c +++ b/revision.c @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s */ if (revs-reverse revs-graph) die(cannot combine --reverse with --graph); - + if (revs-no_walk revs-graph) + die(cannot combine --no-walk with --graph); if (revs-reflog_info revs-graph) die(cannot combine --walk-reflogs with --graph); if (!revs-reflog_info revs-grep_filter.use_reflog_filter) Needs a new test to make sure log --no-walk --graph is rejected, and also you need to make sure all other existing tests that used to pass before this change still pass. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage
Thanks Junio. Working on v2 for this patch. On Sat, Mar 7, 2015 at 12:00 AM, Junio C Hamano gits...@pobox.com wrote: Akshay Aurora akshayaur...@yahoo.com writes: Signed-off-by: Akshay Aurora akshayaur...@yahoo.com --- This is my first patch for a GSoC Microproject, would be great to have your feedback. revision.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/revision.c b/revision.c index bd027bc..d578652 100644 --- a/revision.c +++ b/revision.c @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s */ if (revs-reverse revs-graph) die(cannot combine --reverse with --graph); - + if (revs-no_walk revs-graph) + die(cannot combine --no-walk with --graph); if (revs-reflog_info revs-graph) die(cannot combine --walk-reflogs with --graph); if (!revs-reflog_info revs-grep_filter.use_reflog_filter) Needs a new test to make sure log --no-walk --graph is rejected, and also you need to make sure all other existing tests that used to pass before this change still pass. -- - Akshay Aurora -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage
On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora akshayaur...@yahoo.com wrote: Not sure, why this mail is not showing on Gmane. I used git to send the email, and tested it by sending the patch to myself before sending it to the list. Gmail knows: Why is this message in Spam? It has a from address in yahoo.com but has failed yahoo.com's required tests for authentication. Learn more Probably filtering settings are less strict. I guess you should use authenticated SMTP thought your email hoster, yahoo here in git-send-email (something like --smtp-server and --smtp-user options, it will ask for password interactively) to avoid it. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage
Not sure, why this mail is not showing on Gmane. I used git to send the email, and tested it by sending the patch to myself before sending it to the list. On Fri, Mar 6, 2015 at 12:40 AM, Akshay Aurora akshayaur...@yahoo.com wrote: Signed-off-by: Akshay Aurora akshayaur...@yahoo.com --- This is my first patch for a GSoC Microproject, would be great to have your feedback. revision.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/revision.c b/revision.c index bd027bc..d578652 100644 --- a/revision.c +++ b/revision.c @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s */ if (revs-reverse revs-graph) die(cannot combine --reverse with --graph); - + if (revs-no_walk revs-graph) + die(cannot combine --no-walk with --graph); if (revs-reflog_info revs-graph) die(cannot combine --walk-reflogs with --graph); if (!revs-reflog_info revs-grep_filter.use_reflog_filter) -- 2.3.1 -- AA -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
