Re: [PATCH] (exit 1) is silly

[Junio C Hamano]

Sebastian Schuberth  writes:

> On 3/22/2016 17:16, Junio C Hamano wrote:
>
>> IMO, this is such a minor thing that once it _is_ in the tree, it's
>> not really worth the patch noise to go and fix it up.
>
> IMO, instead of writing this you could have just accepted the patch,
> reducing the patch noise ;-)

"patch noise" does not mean the volume of the list traffic.  It is
the number of pointless changes in the history of the project, and
accepting this patch would _encourage_ similar pointless changes,
i.e. "patch noise".


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] (exit 1) is silly

[Sebastian Schuberth]

On 3/22/2016 17:16, Junio C Hamano wrote:


IMO, this is such a minor thing that once it _is_ in the tree, it's
not really worth the patch noise to go and fix it up.


IMO, instead of writing this you could have just accepted the patch, 
reducing the patch noise ;-)


Regards,
Sebastian


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] (exit 1) is silly

[Junio C Hamano]

izabera  writes:

> Signed-off-by: izabera 
> ---
>  GIT-VERSION-GEN | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index b5072a2..17b6ef4 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -14,7 +14,7 @@ then
>  elif test -d ${GIT_DIR:-.git} -o -f .git &&
>   VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
>   case "$VN" in
> - *$LF*) (exit 1) ;;
> + *$LF*) false ;;
>   v[0-9]*)
>   git update-index -q --refresh
>   test -z "$(git diff-index --name-only HEAD --)" ||

IMO, this is such a minor thing that once it _is_ in the tree, it's
not really worth the patch noise to go and fix it up.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html