Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing

2018-10-10 Thread Junio C Hamano
Daniels Umanovskis  writes:

> On 10/11/18 12:26 AM, Junio C Hamano wrote:
>> Among the remaining ones in the list, cherry and get-tar-commit-id
>> are probably better classified as plumbing.  I do not know why
>> cherry is marked for completion; perhaps some crazy people use that
>> on the command line?
>
> I think cherry could go either way, get-tar-commit-id is definitely
> plumbing. Would you like me to fix those two on the same patch then?

No, what you sent for rev-parse is already good.  A separate patch
that addresses other ones can be discussed as an orthogonal matter.
It even may deserve to make them two separate patches, as I
anticipate that some people would resist marking "cherry" as
plumbing, so that only one can be applied while dropping the other
as/if needed.

Thanks.



Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing

2018-10-10 Thread Daniels Umanovskis
On 10/11/18 12:26 AM, Junio C Hamano wrote:
> Among the remaining ones in the list, cherry and get-tar-commit-id
> are probably better classified as plumbing.  I do not know why
> cherry is marked for completion; perhaps some crazy people use that
> on the command line?

I think cherry could go either way, get-tar-commit-id is definitely
plumbing. Would you like me to fix those two on the same patch then?



Re: [PATCH] doc: move git-rev-parse from porcelain to plumbing

2018-10-10 Thread Junio C Hamano
Daniels Umanovskis  writes:

> git-rev-parse mostly seems like plumbing, and is more usd in
> scripts than in regular use. Online it's often mentioned as
> a plumbing command. Nonetheless it's listed under porcelain
> interrogators in `man git`. It seems appropriate to formally
> move git-rev-parse to plumbing interrogators.

Correct.  "ancillary" category ended up with full of Porcelain, it
seems, but there still are plumbing commands there, and this is a
prime example that should not be mixed up with Porcelain commands.

Among the remaining ones in the list, cherry and get-tar-commit-id
are probably better classified as plumbing.  I do not know why
cherry is marked for completion; perhaps some crazy people use that
on the command line?