Re: [PATCH] t/t7502-commit.sh : remove a repeated test

[Pranit Bauva]

On Fri, Mar 11, 2016 at 4:51 AM, Eric Sunshine  wrote:
>> t/t7502-commit.sh : remove a repeated test
>
> Or:
>
> t7502: drop duplicate test
>

Sure!

>> This extra test was introducted in the commit f9c01817
>
> We normally add some parenthetical context when mentioning commits:
>
> This extra test was introduced erroneously by
> f9c0181 (t7502: test commit.status, --status and
> --no-status, 2010-01-13)

Seems like I have to yet get comfortable with the language used here.
I will start reading more commits and stuff.

I will resend the patch with the specified edits.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] t/t7502-commit.sh : remove a repeated test

[Eric Sunshine]

On Thu, Mar 10, 2016 at 5:51 PM, Pranit Bauva  wrote:
> t/t7502-commit.sh : remove a repeated test

Or:

t7502: drop duplicate test

> This extra test was introducted in the commit f9c01817

We normally add some parenthetical context when mentioning commits:

This extra test was introduced erroneously by
f9c0181 (t7502: test commit.status, --status and
--no-status, 2010-01-13)

The patch itself makes sense. Thanks.

> Signed-off-by: Pranit Bauva 
> ---
>  t/t7502-commit.sh | 5 -
>  1 file changed, 5 deletions(-)
>
> diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
> index b39e313..725687d 100755
> --- a/t/t7502-commit.sh
> +++ b/t/t7502-commit.sh
> @@ -527,11 +527,6 @@ try_commit_status_combo () {
> test_i18ngrep "^# Changes to be committed:" 
> .git/COMMIT_EDITMSG
> '
>
> -   test_expect_success 'commit' '
> -   try_commit "" &&
> -   test_i18ngrep "^# Changes to be committed:" 
> .git/COMMIT_EDITMSG
> -   '
> -
> test_expect_success 'commit --status' '
> try_commit --status &&
> test_i18ngrep "^# Changes to be committed:" 
> .git/COMMIT_EDITMSG
>
> --
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html