Re: [PATCH 0/2] Really fix the isatty() problem on Windows

2016-12-22 Thread Johannes Schindelin 
Hi Hannes,

On Thu, 22 Dec 2016, Johannes Sixt wrote:

> Am 21.12.2016 um 22:15 schrieb Johannes Sixt:
> > Am 21.12.2016 um 18:53 schrieb Johannes Schindelin:
> > > The current patch series is based on `pu`, as that already has the
> > > winansi_get_osfhandle() fix. For ease of testing, I also have a branch
> > > based on master which you can pull via
> > >
> > > git pull https://github.com/dscho/git mingw-isatty-fixup-master
> >
> > Will test and report back tomorrow.
> 
> This version 1 of the series passes the test suite (next + a handful other
> topics) for me. It has also undergone a bit of field testing, and things look
> fine.
> 
> I haven't looked at the resulting code, yet, but I don't expect to find
> anything fishy.

Thanks for confirming!
Dscho

Re: [PATCH 0/2] Really fix the isatty() problem on Windows

2016-12-22 Thread Johannes Sixt 

Am 21.12.2016 um 22:15 schrieb Johannes Sixt:

Am 21.12.2016 um 18:53 schrieb Johannes Schindelin:

The current patch series is based on `pu`, as that already has the
winansi_get_osfhandle() fix. For ease of testing, I also have a branch
based on master which you can pull via

git pull https://github.com/dscho/git mingw-isatty-fixup-master


Will test and report back tomorrow.


This version 1 of the series passes the test suite (next + a handful 
other topics) for me. It has also undergone a bit of field testing, and 
things look fine.


I haven't looked at the resulting code, yet, but I don't expect to find 
anything fishy.


-- Hannes

Re: [PATCH 0/2] Really fix the isatty() problem on Windows

2016-12-21 Thread Junio C Hamano 
Johannes Sixt  writes:

> Am 21.12.2016 um 18:53 schrieb Johannes Schindelin:
>> The current patch series is based on `pu`, as that already has the
>> winansi_get_osfhandle() fix. For ease of testing, I also have a branch
>> based on master which you can pull via
>>
>>  git pull https://github.com/dscho/git mingw-isatty-fixup-master
>
> Will test and report back tomorrow.

Thanks.

Re: [PATCH 0/2] Really fix the isatty() problem on Windows

2016-12-21 Thread Johannes Sixt 

Am 21.12.2016 um 18:53 schrieb Johannes Schindelin:

The current patch series is based on `pu`, as that already has the
winansi_get_osfhandle() fix. For ease of testing, I also have a branch
based on master which you can pull via

git pull https://github.com/dscho/git mingw-isatty-fixup-master


Will test and report back tomorrow.

-- Hannes