Re: [PATCH 0/3] fix test suite with mingw-unicode patches
Hello Karsten, thanks for your analysis. Most of the patches you refer to are simply switching off tests for MINGW; let me comment on the remaining ones: * t0110-urlmatch-normalization: 1 Passing binary data on the command line...would have to teach test-urlmatch-normalization.c to read from stdin or file. https://github.com/msysgit/git/commit/be0d6dee Indeed, that would be better solution. For now, I'm going to submit the switch-off patch you mention. * t4036-format-patch-signer-mime: 1 Passing non-ASCII by environment variable, will be fixed by Unicode environment support. Will submit that patch series soon. * t7001-mv: 6 cp -P fails in MinGW - perhaps use the long option forms (--no-dereference)? cp -P fails with our 2001-edition of cp, so msysgit had to revert: https://github.com/msysgit/git/commit/6d3e23d4 But I was ashamed to mention that upstream; and I hope mingwGitDevEnv is going to solve that. * t8001-annotate/t8002-blame: 5 Msys.dll thinks '-L/regex/' is an absolute path and expands to '-LC:/msysgit/regex/'. https://github.com/msysgit/git/commit/2d52168a Nice! But I'm afraid the patch cannot be submitted upstream as it is. I think the hack could be automated by processing options -L* this way: sed 'sX\(^-L\|,\)\^\?/X\\;*Xg' Then it would become only few lines at the top of the script, executed on mingw only. I hope to submit the patch in this form soon. Have a nice day, Stepan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] fix test suite with mingw-unicode patches
Am 16.07.2014 11:29, schrieb Stepan Kasal: * t7001-mv: 6 cp -P fails in MinGW - perhaps use the long option forms (--no-dereference)? cp -P fails with our 2001-edition of cp, so msysgit had to revert: https://github.com/msysgit/git/commit/6d3e23d4 But I was ashamed to mention that upstream; and I hope mingwGitDevEnv is going to solve that. Yes it does. cp in mingwGitDevEnv is from coreutils 5.97 and knows about -P. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] fix test suite with mingw-unicode patches
Hello, I'm sorry that I have to reply to my own mail, but I forgot this: Karsten Blees (2): Win32: Unicode file name support (except dirent) .. has this one squashed in: Win32: fix detection of empty directories in is_dir_empty https://github.com/msysgit/git/commit/91db148 Win32: Unicode file name support (dirent) Both of theese patches are in msysgit for more than 2 years. Pat Thoyts and Stepan Kasal(1): tests: do not pass iso8859-1 encoded parameter This one is relatively new: replaces git commit -m by git commit -F - to work around a Windows bug^H^H^Hfeature. Stepan -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] fix test suite with mingw-unicode patches
Stepan Kasal ka...@ucw.cz writes: Hello Hannes, attached please find the patches that Karsten pointed out: 1) The unicode file name support was omitted from his unicode patch series; my mistake, sorry. There is still big part missing: support for unicode environment; I can only hope the tests would choke on that. 2) Windows cannot pass non-UTF parameters (commit messages in this case): original patch by Pat Thoyts was extended to apply to other similar cases: the commit msg is passed through stdin. If there are still problems remaining, please tell us. Thanks, Stepan Karsten Blees (2): Win32: Unicode file name support (except dirent) Win32: Unicode file name support (dirent) Pat Thoyts and Stepan Kasal(1): tests: do not pass iso8859-1 encoded parameter Thanks. I'll queue these and wait for Windows folks to respond. With favourable feedback they can go directly from pu to master, I would think. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] fix test suite with mingw-unicode patches
Am 15.07.2014 20:20, schrieb Junio C Hamano: Stepan Kasal ka...@ucw.cz writes: Hello Hannes, attached please find the patches that Karsten pointed out: 1) The unicode file name support was omitted from his unicode patch series; my mistake, sorry. There is still big part missing: support for unicode environment; I can only hope the tests would choke on that. 2) Windows cannot pass non-UTF parameters (commit messages in this case): original patch by Pat Thoyts was extended to apply to other similar cases: the commit msg is passed through stdin. If there are still problems remaining, please tell us. Thanks, Stepan Karsten Blees (2): Win32: Unicode file name support (except dirent) Win32: Unicode file name support (dirent) Pat Thoyts and Stepan Kasal(1): tests: do not pass iso8859-1 encoded parameter Thanks. I'll queue these and wait for Windows folks to respond. With favourable feedback they can go directly from pu to master, I would think. Looking good. After fixing the ELOOP and fchmod issues (see followup patches), there are 9 test failures left. Only one of these is environment related, and for the rest we have fixes in the msysgit fork: * t0081-line-buffer: 1 Using file descriptor other than 0, 1, 2. https://github.com/msysgit/git/commit/4940c51a * t0110-urlmatch-normalization: 1 Passing binary data on the command line...would have to teach test-urlmatch-normalization.c to read from stdin or file. https://github.com/msysgit/git/commit/be0d6dee * t4036-format-patch-signer-mime: 1 not ok 4 - format with non ASCII signer name # # GIT_COMMITTER_NAME=はまの ふにおう \ # git format-patch -s --stdout -1 output # grep Content-Type output # Passing non-ASCII by environment variable, will be fixed by Unicode environment support. * t4201-shortlog: 3 Passing binary data on the command line ('git-commit -m'). https://github.com/msysgit/git/commit/3717ce1b * t4210-log-i18n: 2 Passing binary data on the command line ('git log --grep=$latin1_e'). https://github.com/msysgit/git/commit/dd2defa3 * t7001-mv: 6 cp -P fails in MinGW - perhaps use the long option forms (--no-dereference)? https://github.com/msysgit/git/commit/00764ca1 * t8001-annotate/t8002-blame: 5 Msys.dll thinks '-L/regex/' is an absolute path and expands to '-LC:/msysgit/regex/'. https://github.com/msysgit/git/commit/2d52168a * t8005-blame-i18n: 4 Passing binary data on the command line ('git-commit --author -m'). https://github.com/msysgit/git/commit/3717ce1b * t9902-completion: 2 Must use 'pwd -W' to get Windows-style absolute paths. https://github.com/msysgit/git/commit/9b612448 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html